7 imagemagick failing doctest in plot/animate.py #28868

seblabbe · 2019-12-10T08:45:18Z

sage -t --optional=sage,imagemagick src/sage/plot/animate.py

gives

Using --optional=imagemagick,memlimit,sage
Doctesting 1 file.
sage -t src/sage/plot/animate.py
**********************************************************************
File "src/sage/plot/animate.py", line 563, in sage.plot.animate.Animation.?
Failed example:
    with open(td + 'my_animation.gif', 'rb') as f: print('\x21\xf9\x04\x08\x23\x00' in f.read())  # optional -- ImageMagick
Exception raised:
    Traceback (most recent call last):
      File "/home/slabbe/GitBox/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 681, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/slabbe/GitBox/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1123, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.plot.animate.Animation.?[3]>", line 1, in <module>
        with open(td + 'my_animation.gif', 'rb') as f: print('\x21\xf9\x04\x08\x23\x00' in f.read())  # optional -- ImageMagick
    TypeError: a bytes-like object is required, not 'str'
**********************************************************************

...

**********************************************************************
File "src/sage/plot/animate.py", line 1068, in sage.plot.animate.Animation.save
Failed example:
    with open(td + 'wave.gif', 'rb') as f: print('!\xff\x0bNETSCAPE2.0\x03\x01\x03\x00\x00' in f.read())  # optional -- ImageMagick
Exception raised:
    Traceback (most recent call last):
      File "/home/slabbe/GitBox/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 681, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/slabbe/GitBox/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1123, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.plot.animate.Animation.save[14]>", line 1, in <module>
        with open(td + 'wave.gif', 'rb') as f: print('!\xff\x0bNETSCAPE2.0\x03\x01\x03\x00\x00' in f.read())  # optional -- ImageMagick
    TypeError: a bytes-like object is required, not 'str'
**********************************************************************
2 items had failures:
   1 of   9 in sage.plot.animate.Animation.?
   6 of  16 in sage.plot.animate.Animation.save
    [208 tests, 7 failures, 57.48 s]
----------------------------------------------------------------------
sage -t src/sage/plot/animate.py  # 7 doctests failed
----------------------------------------------------------------------

Component: graphics

Author: Frédéric Chapoton

Branch/Commit: 41a0543

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28868

The text was updated successfully, but these errors were encountered:

fchapoton · 2019-12-13T20:15:30Z

Author: Frédéric Chapoton

fchapoton · 2019-12-13T20:15:30Z

Branch: u/chapoton/28868

fchapoton · 2019-12-13T20:15:30Z

Commit: c011c93

fchapoton · 2019-12-13T20:15:30Z

New commits:

`c011c93`	`fix optional imagemagick doctests in animate`

fchapoton · 2019-12-14T13:14:33Z

comment:3

does not work

embray · 2020-01-06T14:10:03Z

comment:4

Ticket retargeted after milestone closed

fchapoton · 2020-04-03T20:09:55Z

comment:5

Sébastien, could you please try the branch here ? It seems that it fixes the bytes problems, but there remains a true failure afterwards.

fchapoton · 2020-04-04T08:15:14Z

comment:6

All tests seem to pass, I just tried.

seblabbe · 2020-04-04T10:18:49Z

comment:7

With the branch on top of 9.1.beta9 I get

Git branch: 28868
Using --optional=imagemagick,memlimit,sage
Doctesting 1 file.
sage -t src/sage/plot/animate.py
**********************************************************************
File "src/sage/plot/animate.py", line 1068, in sage.plot.animate.Animation.save
Failed example:
    with open(td + 'wave.gif', 'rb') as f: print(b'!\xff\x0bNETSCAPE2.0\x03\x01\x02\x00\x00' in f.read())  # optional -- ImageMagick
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of  16 in sage.plot.animate.Animation.save
    [208 tests, 1 failure, 57.01 s]
----------------------------------------------------------------------
sage -t src/sage/plot/animate.py  # 1 doctest failed
----------------------------------------------------------------------

fchapoton · 2020-04-04T10:27:31Z

comment:8

ok. Je propose de faire passer la branche, et de garder le dernier probleme pour un autre ticket. Après tout, c'est un autre probleme, certes au meme endroit.

seblabbe · 2020-04-04T10:34:59Z

comment:9

J'ai identifié le soucis. Le dernier changement que tu fait remplace aussi un \x03 par un \x02:

- sage: with open(td + 'wave.gif', 'rb') as f: print('!\xff\x0bNETSCAPE2.0\x03\x01\x03\x00\x00' in f.read())  # optional -- ImageMagick
+ sage: with open(td + 'wave.gif', 'rb') as f: print(b'!\xff\x0bNETSCAPE2.0\x03\x01\x02\x00\x00' in f.read())  # optional -- ImageMagick

Si je garde le \x03, alors chez moi le test passe.

seblabbe · 2020-04-04T10:36:56Z

comment:10

Si chez toi, tu as besoin de garder le \x02, je suggère alors de garder que le préfixe commun
b'!\xff\x0bNETSCAPE2.0\x03\x01 pour le dernier test.

fchapoton · 2020-04-04T11:42:03Z

comment:11

Chez moi, ca foire quand je mets \x03 et ca passe quand je mets \x02

Je veux bien ne garder que le prefixe commun, mais est-ce que ca ne supprime pas tout l'interet du doctest ?

seblabbe · 2020-04-04T18:34:19Z

comment:12

Je veux bien ne garder que le prefixe commun, mais est-ce que ca ne supprime pas tout l'interet du doctest ?

The saved file wave.gif works as expected on my machine. What about yours?

fchapoton · 2020-04-04T19:43:50Z

comment:13

Il me semble que oui. Je l'attache

fchapoton · 2020-04-04T19:44:09Z

Attachment: wave.gif

fchapoton · 2020-04-04T19:44:47Z

comment:14

faudrait voir si il s'arrete au meme point que chez toi

seblabbe · 2020-04-04T20:49:28Z

comment:15

Oui, c'est pareil. Du coup, allons y avec le préfixe commun.

sagetrac-git · 2020-04-05T07:00:52Z

Changed commit from c011c93 to d991581

sagetrac-git · 2020-04-05T07:00:52Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2b0806e`	`Merge branch 'u/chapoton/28868' of ssh://trac.sagemath.org:22/sage into img`
`d991581`	`allow either imagemagick doctest`

fchapoton · 2020-04-05T07:02:14Z

comment:17

j'ai eu une autre idee : verifier la presence d'une des deux chaines. Ca me semble mieux respecter l'esprit du doctest. Voir le dernier commit

seblabbe · 2020-04-05T11:19:35Z

comment:18

sage -t src/sage/plot/animate.py
    [208 tests, 57.03 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------

seblabbe · 2020-04-05T11:19:35Z

Reviewer: Sébastien Labbé

vbraun · 2020-04-08T21:32:36Z

comment:19

[dochtml] OSError: /amd/compute/sagebot/sage/local/lib/python3.7/site-packages/sage/plot/animate.py:docstring of sage.plot.animate.animate:11: WARNING: Duplicate explicit target name: "imagemagick".

fchapoton · 2020-04-09T15:52:47Z

comment:21

oh boy, what's that ?

Could it be caused by

-- `ImageMagick <http://www.imagemagick.org>`_
+- `ImageMagick <https://www.imagemagick.org>`_

?

sagetrac-git · 2020-04-09T16:00:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`41a0543`	`fix references in plot/animate`

sagetrac-git · 2020-04-09T16:00:26Z

Changed commit from d991581 to 41a0543

fchapoton · 2020-04-09T16:01:17Z

comment:23

Here is probably a fix commit. Please review.

seblabbe · 2020-04-10T07:40:36Z

comment:24

Oups, the patchbot were telling us that problem for a while...

I think you can't have the same reference link twice in the same file. It must be because of that. I manage to build the doc correctly on my side. Patchbot light is green this time. Good to go.

vbraun · 2020-04-16T22:33:32Z

Changed branch from u/chapoton/28868 to 41a0543

seblabbe added this to the sage-9.0 milestone Dec 10, 2019

seblabbe added c: graphics labels Dec 10, 2019

seblabbe changed the title ~~1 imagemagick failing doctest in plot/animate.py~~ 7 imagemagick failing doctest in plot/animate.py Dec 10, 2019

fchapoton added the s: needs review label Dec 13, 2019

fchapoton added s: needs work and removed s: needs review labels Dec 14, 2019

embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020

fchapoton added s: needs review and removed s: needs work labels Apr 3, 2020

seblabbe added s: positive review and removed s: needs review labels Apr 5, 2020

vbraun added s: needs work and removed s: positive review labels Apr 8, 2020

fchapoton added s: needs review and removed s: needs work labels Apr 9, 2020

seblabbe added s: positive review and removed s: needs review labels Apr 10, 2020

vbraun removed the s: positive review label Apr 16, 2020

vbraun closed this as completed in 12367fd Apr 16, 2020

seblabbe mentioned this issue Oct 21, 2022

meta-ticket: failing internet/optional doctests #25536

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7 imagemagick failing doctest in plot/animate.py #28868

7 imagemagick failing doctest in plot/animate.py #28868

seblabbe commented Dec 10, 2019

fchapoton commented Dec 13, 2019

fchapoton commented Dec 13, 2019

fchapoton commented Dec 13, 2019

fchapoton commented Dec 13, 2019

fchapoton commented Dec 14, 2019

embray commented Jan 6, 2020

fchapoton commented Apr 3, 2020

fchapoton commented Apr 4, 2020

seblabbe commented Apr 4, 2020

fchapoton commented Apr 4, 2020

seblabbe commented Apr 4, 2020

seblabbe commented Apr 4, 2020

fchapoton commented Apr 4, 2020

seblabbe commented Apr 4, 2020

fchapoton commented Apr 4, 2020

fchapoton commented Apr 4, 2020

fchapoton commented Apr 4, 2020

seblabbe commented Apr 4, 2020

sagetrac-git mannequin commented Apr 5, 2020

sagetrac-git mannequin commented Apr 5, 2020

fchapoton commented Apr 5, 2020

seblabbe commented Apr 5, 2020

seblabbe commented Apr 5, 2020

vbraun commented Apr 8, 2020

fchapoton commented Apr 9, 2020

sagetrac-git mannequin commented Apr 9, 2020

sagetrac-git mannequin commented Apr 9, 2020

fchapoton commented Apr 9, 2020

seblabbe commented Apr 10, 2020

vbraun commented Apr 16, 2020

7 imagemagick failing doctest in plot/animate.py #28868

7 imagemagick failing doctest in plot/animate.py #28868

Comments

seblabbe commented Dec 10, 2019

fchapoton commented Dec 13, 2019

fchapoton commented Dec 13, 2019

fchapoton commented Dec 13, 2019

fchapoton commented Dec 13, 2019

fchapoton commented Dec 14, 2019

embray commented Jan 6, 2020

fchapoton commented Apr 3, 2020

fchapoton commented Apr 4, 2020

seblabbe commented Apr 4, 2020

fchapoton commented Apr 4, 2020

seblabbe commented Apr 4, 2020

seblabbe commented Apr 4, 2020

fchapoton commented Apr 4, 2020

seblabbe commented Apr 4, 2020

fchapoton commented Apr 4, 2020

fchapoton commented Apr 4, 2020

fchapoton commented Apr 4, 2020

seblabbe commented Apr 4, 2020

sagetrac-git mannequin commented Apr 5, 2020

sagetrac-git mannequin commented Apr 5, 2020

fchapoton commented Apr 5, 2020

seblabbe commented Apr 5, 2020

seblabbe commented Apr 5, 2020

vbraun commented Apr 8, 2020

fchapoton commented Apr 9, 2020

sagetrac-git mannequin commented Apr 9, 2020

sagetrac-git mannequin commented Apr 9, 2020

fchapoton commented Apr 9, 2020

seblabbe commented Apr 10, 2020

vbraun commented Apr 16, 2020