Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sympy to 1.5 #28911

Closed
antonio-rojas opened this issue Dec 25, 2019 · 12 comments
Closed

Update sympy to 1.5 #28911

antonio-rojas opened this issue Dec 25, 2019 · 12 comments

Comments

@antonio-rojas
Copy link
Contributor

Removed merged match, updated a few doctest results

Tarball: https://github.com/sympy/sympy/releases/download/sympy-1.5/sympy-1.5.tar.gz

CC: @kiwifb @timokau @saraedum @slel

Component: packages: standard

Author: Antonio Rojas

Branch/Commit: c6d0308

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/28911

@antonio-rojas antonio-rojas added this to the sage-9.0 milestone Dec 25, 2019
@antonio-rojas
Copy link
Contributor Author

Branch: u/arojas/update_sympy_to_1_5

@antonio-rojas
Copy link
Contributor Author

Commit: c6d0308

@antonio-rojas

This comment has been minimized.

@antonio-rojas
Copy link
Contributor Author

Author: Antonio Rojas

@antonio-rojas
Copy link
Contributor Author

New commits:

c6d0308Update sympy to 1.5

@kiwifb
Copy link
Member

kiwifb commented Dec 26, 2019

comment:3

Finally got rid of that patch? That's awesome news.

I am not familiar with lambert_w but that test in sage/symbolic/relation.py should be checked by someone who knows if it is correct. The other tests are just a matter of factorization.

@antonio-rojas
Copy link
Contributor Author

comment:4

Both are correct,

lambert_w(±1/2) = ±(1/2)exp(-lambert_w(±1/2))

so

(2·lambert_w(±1/2))^2 = 1/exp(2·lambert_w(±1/2))

@kiwifb
Copy link
Member

kiwifb commented Dec 26, 2019

comment:5

Replying to @antonio-rojas:

Both are correct,

lambert_w(±1/2) = ±(1/2)exp(-lambert_w(±1/2))

so

(2·lambert_w(±1/2))^2 = 1/exp(2·lambert_w(±1/2))

Now, I understand, it is just another root of the equation and the order in which they are stored has changed. It all looks good to me.

@kiwifb
Copy link
Member

kiwifb commented Dec 26, 2019

Reviewer: François Bissey

@timokau
Copy link
Contributor

timokau commented Dec 26, 2019

comment:6

Thank you for taking care of this!

@fchapoton
Copy link
Contributor

comment:7

9.0 is out

@fchapoton fchapoton modified the milestones: sage-9.0, sage-9.1 Jan 1, 2020
@vbraun
Copy link
Member

vbraun commented Jan 5, 2020

Changed branch from u/arojas/update_sympy_to_1_5 to c6d0308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants