Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some details about all(...) and return #28972

Closed
fchapoton opened this issue Jan 8, 2020 · 11 comments
Closed

some details about all(...) and return #28972

fchapoton opened this issue Jan 8, 2020 · 11 comments
Labels
c: geometry p: minor / 4 t: enhancement
Milestone
sage-9.1

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: geometry

Author: Frédéric Chapoton

Branch/Commit: 3b38acf

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28972
@fchapoton fchapoton added this to the sage-9.1 milestone Jan 8, 2020
@fchapoton
Copy link
Contributor Author

New commits:

5e1a872fix some details in dynamics and rings (return is not a function)

@fchapoton
Copy link
Contributor Author

Commit: 5e1a872

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/all_and_return

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Jan 9, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 9, 2020

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Jan 10, 2020

comment:4

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2020

Changed commit from 5e1a872 to 3b38acf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

3b38acfMerge branch 'u/chapoton/all_and_return' in 9.1.b0

@fchapoton
Copy link
Contributor Author

comment:6

fixed the trivial conflict, setting back to positive

@vbraun
Copy link
Member

vbraun commented Jan 18, 2020

Changed branch from u/chapoton/all_and_return to 3b38acf

@vbraun vbraun closed this as completed in e13339b Jan 18, 2020
@fchapoton fchapoton mentioned this issue Jan 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton