Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ./configure --help a bit shorter by combining --with-system-SPKG and --with-system-SPK=force #29067

Closed
mkoeppe opened this issue Jan 22, 2020 · 15 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jan 22, 2020

Also sort the --with-system-SPKG options alphabetically.

Purely cosmetic.

CC: @embray @dimpase @jhpalmieri

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 1269b08

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29067

@mkoeppe mkoeppe added this to the sage-9.1 milestone Jan 22, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 22, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 22, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 22, 2020

comment:3

It still has some minor difficulties with the alphabet but is better than before.


New commits:

6d7eb15bootstrap: Sort the spkg-configure.m4's alphabetically so that --with-system-SPKG options are sorted
5df3c68m4/sage_spkg_configure.m4: Combine --with-system-SPKG and --with-system-SPK=force in configure --help output

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 22, 2020

Commit: 5df3c68

@dimpase
Copy link
Member

dimpase commented Jan 23, 2020

comment:5

Could you swap yes and no in {no|yes|force}, as yes is the default value?

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 23, 2020

comment:6

Is that the standard? I have sorted them in increasing yes-ness

@dimpase
Copy link
Member

dimpase commented Jan 23, 2020

comment:7

maybe

--- a/m4/sage_spkg_configure.m4
+++ b/m4/sage_spkg_configure.m4
@@ -51,8 +51,8 @@ m4_pushdef([SPKG_USE_SYSTEM], [sage_use_system_]SPKG_NAME)
 # BEGIN SAGE_SPKG_CONFIGURE_]m4_toupper($1)[
 AC_MSG_NOTICE([=== checking whether to install the $1 SPKG ===])
 AC_ARG_WITH([system-]SPKG_NAME,
-       AS_HELP_STRING(--with-system-SPKG_NAME={no|yes|force},
-           [detect and use an existing system SPKG_NAME (default: "yes"; "force": exit with an error if no usable version is found)]),
+       AS_HELP_STRING(--with-system-SPKG_NAME={no|yes (default)|force (exit with an error if no usable version is found)},
+           [detect and use an existing system SPKG_NAME]),
        [AS_VAR_SET(SPKG_USE_SYSTEM, [$withval])],
        [AS_VAR_SET(SPKG_USE_SYSTEM, [yes])]
 )

?

this saves a line per spkg.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 23, 2020

comment:8

Fine with me, please commit

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 23, 2020

comment:9

Actually the default is more subtle because a previous choice of "no" persists as the effective default through SAGE_LOCAL.

@dimpase
Copy link
Member

dimpase commented Jan 23, 2020

Changed commit from 5df3c68 to 1269b08

@dimpase
Copy link
Member

dimpase commented Jan 23, 2020

New commits:

1269b08save 1 line per spkg

@dimpase
Copy link
Member

dimpase commented Jan 23, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 23, 2020

comment:12

Thank you!

@vbraun
Copy link
Member

vbraun commented Jan 25, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants