Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One-line fix for blocker ".pc files generated in src/ are not cleaned by make misc-clean / make distclean #29121

Closed
mkoeppe opened this issue Jan 31, 2020 · 8 comments
Closed

One-line fix for blocker ".pc files generated in src/ are not cleaned by make misc-clean / make distclean #29121

mkoeppe opened this issue Jan 31, 2020 · 8 comments
Labels
c: build: configure p: blocker / 1 t: bug
Milestone
sage-9.1

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jan 31, 2020

This is a hot fix for the blocker regression introduced in #29003. It should go into the next beta.

It will be easier to review than the complete solution at:

CC: @dimpase @embray @vbraun

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: c06fc37

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29121
@mkoeppe mkoeppe added this to the sage-9.1 milestone Jan 31, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 31, 2020

Branch: u/mkoeppe/one_line_fix_for_blocker___pc_files_generated_in_src__are_not_cleaned_by__make_misc_clean_____make_distclean_

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 31, 2020

New commits:

c06fc37Makefile [misc-clean]: Delete configure-generated files src/lib/pkgconfig/*

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 31, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 31, 2020

Commit: c06fc37

@dimpase
Copy link
Member

dimpase commented Jan 31, 2020

comment:3

lgtm

@dimpase
Copy link
Member

dimpase commented Jan 31, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 31, 2020

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Feb 10, 2020

Changed branch from u/mkoeppe/one_line_fix_for_blocker___pc_files_generated_in_src__are_not_cleaned_by__make_misc_clean_____make_distclean_ to c06fc37

@vbraun vbraun closed this as completed in f4f06c6 Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe