Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass the installation prefix of libffi to ECL #29128

Closed
dimpase opened this issue Jan 31, 2020 · 6 comments
Closed

pass the installation prefix of libffi to ECL #29128

dimpase opened this issue Jan 31, 2020 · 6 comments

Comments

@dimpase
Copy link
Member

dimpase commented Jan 31, 2020

at present ECL installation takes the headers of libffi from whereever it can, and first of all from "standard" locations. Thus an imcompatible libffi headers (and version 3.3 introduced an apparent incompatibility) installed system-wide break building of ECL even though --without-system-ecl is given.

This was reported to happen on Debian testing.
(And an earlier related ticket is #21811). The initial debugging started on this thread of sage-devel.

ECL's configure has an option --with-libffi-prefix=path which hopefully does the job (untested); if so, this would at least allow
the build to succeed in such a configuration.

Another task is to test for the incompatible libffi (well, we can just test the version not to be above 3.2.x for some x).

CC: @mkoeppe @isuruf @embray @kiwifb @EmmanuelCharpentier @mezzarobba

Component: build

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29128

@dimpase dimpase added this to the sage-9.1 milestone Jan 31, 2020
@dimpase

This comment has been minimized.

@EmmanuelCharpentier

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented Feb 3, 2020

comment:4

In upstream ECL it's addressed in https://gitlab.com/embeddable-common-lisp/ecl/issues/302

So we hopefully can backport this to out 16.1.2, and support all versions of libffi, old and current.

@dimpase
Copy link
Member Author

dimpase commented Feb 3, 2020

comment:5

the ECL's option appears not be working, anyway, on #21811 there is a better solution.
We'll fix the issue on #21811

@dimpase dimpase removed this from the sage-9.1 milestone Feb 3, 2020
@tscrim
Copy link
Collaborator

tscrim commented Feb 8, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 8, 2020

comment:6

Since #21811 is a better solution and positively reviewed, I agree with closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants