Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional package sirocco broken on Cygwin #29149

Closed
embray opened this issue Feb 3, 2020 · 10 comments
Closed

Optional package sirocco broken on Cygwin #29149

embray opened this issue Feb 3, 2020 · 10 comments
Assignees
@embray
Labels
c: packages: optional c: porting: cygwin p: major / 3 t: bug

Comments

@embray
Copy link
Contributor

embray commented Feb 3, 2020

The package builds, but sagelib fails to link to it. The problem seems to be a __declspec(dllimport) issue, so it's probably easily fixed.

Upstream PR: miguelmarco/SIROCCO2#5

Depends on #29167

Upstream: Fixed upstream, but not in a stable release.

CC: @miguelmarco

Component: packages: optional

Keywords: sirocco cygwin

Author: Erik Bray

Branch/Commit: u/embray/ticket-29149 @ 2a7d4ff

Reviewer: Miguel Marco

Issue created by migration from https://trac.sagemath.org/ticket/29149
@embray embray added this to the sage-9.1 milestone Feb 3, 2020
@embray embray self-assigned this Feb 3, 2020
@embray
Copy link
Contributor Author

embray commented Feb 10, 2020

Branch: u/embray/ticket-29149

@embray
Copy link
Contributor Author

embray commented Feb 10, 2020

Commit: 2a7d4ff

@embray
Copy link
Contributor Author

embray commented Feb 10, 2020

comment:2

This fixes the original problem described in this ticket. It also depends on #29167 for sirocco to build properly on Cygwin without errors.

New commits:

35d7703Trac #29167: Fix incorrect results that occur when sirocco is build with
2a7d4ffTrac #29149: Fix building sirocco as a shared library on Cygwin

@embray
Copy link
Contributor Author

embray commented Feb 10, 2020

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented Feb 10, 2020

Dependencies: #29167

@embray

This comment has been minimized.

Sign in to view
@embray
Copy link
Contributor Author

embray commented Feb 17, 2020

Upstream: Fixed upstream, but not in a stable release.

@mkoeppe
Copy link
Member

mkoeppe commented Apr 22, 2020

comment:4

Is this fixed by #29284 (upgrade SPKG to 2.0.2)?

@mkoeppe mkoeppe removed this from the sage-9.1 milestone Apr 22, 2020
@miguelmarco
Copy link
Contributor

comment:5

Yes, it is solved.

@mkoeppe
Copy link
Member

mkoeppe commented Apr 23, 2020

Reviewer: Miguel Marco

@embray embray mentioned this issue Mar 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@embray embray

Labels
c: packages: optional c: porting: cygwin p: major / 3 t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@embray @miguelmarco @fchapoton @mkoeppe