Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginner Ticket: Note to remind GitHub users of their trac username #29178

Closed
Tinkidinki mannequin opened this issue Feb 11, 2020 · 14 comments
Closed

Beginner Ticket: Note to remind GitHub users of their trac username #29178

Tinkidinki mannequin opened this issue Feb 11, 2020 · 14 comments

Comments

@Tinkidinki
Copy link
Mannequin

Tinkidinki mannequin commented Feb 11, 2020

One can authenticate themselves on the trac server in two ways. Either they have a trac username and password, or via GitHub.

To be authenticated via GitHub, following the steps on the Collaborative Development with Git-Trachttps://doc.sagemath.org/html/en/developer/git_trac.html page, one would log onto the trac server and generate a token, and then type the following command in the terminal as given in the documentation:

git trac config --user=<username> --token=<token>

However, it is extremely easy to miss the fact that the username to be entered here is NOT the GitHub username, but rather the trac username which is gh-<GitHub-username> as given on the top right corner of the trac server.

This ticket is basically to add a note in the page: https://doc.sagemath.org/html/en/developer/git_trac.html reminding new developers of their trac username.

One would have to find where in the sage directory structure the documentation file exists, make the relevant changes and commit.

Component: documentation

Keywords: authentication, developer

Author: Vishesh Tayal

Branch/Commit: 749b230

Reviewer: Divesh Kumar

Issue created by migration from https://trac.sagemath.org/ticket/29178

@Tinkidinki Tinkidinki mannequin added this to the sage-9.1 milestone Feb 11, 2020
@unicorn-io
Copy link
Mannequin

unicorn-io mannequin commented Feb 22, 2020

Attachment: git_trac.rst.gz

Added a note in the GIt and Trac Configuration Section

@unicorn-io unicorn-io mannequin added the s: needs review label Feb 22, 2020
@unicorn-io
Copy link
Mannequin

unicorn-io mannequin commented Feb 22, 2020

Attachment: git_trac.2.rst.gz

@unicorn-io
Copy link
Mannequin

unicorn-io mannequin commented Feb 22, 2020

Author: gh-unicorn-io

@unicorn-io
Copy link
Mannequin

unicorn-io mannequin commented Feb 23, 2020

@Karn-Tiwari-3003
Copy link
Mannequin

Karn-Tiwari-3003 mannequin commented Feb 27, 2020

comment:4

If you are authenticating through GitHub on trac server then it's better you use OAuth directly provided by Github which is a much easier way of authenticating.


New commits:

5025160Added note for Trac users regarding their usernames while configuration
3cf67afRevert "Added note for Trac users regarding their usernames while configuration"
749b230Added a note to user regarding their trac username while configuring.

@Karn-Tiwari-3003
Copy link
Mannequin

Karn-Tiwari-3003 mannequin commented Feb 27, 2020

Commit: 749b230

@diveshkr-code
Copy link
Mannequin

diveshkr-code mannequin commented Mar 10, 2020

comment:5

Build the developer manual with --docbuild and viewed it with web browser everything looked good hence giving positive review.
Reviewer Name: Divesh Kumar

@vbraun
Copy link
Member

vbraun commented Mar 11, 2020

comment:6

Reviewer name is missing

Author name should be the real name (unless you want to be listed at gh-unicorn-io in the release notes)

@diveshkr-code
Copy link
Mannequin

diveshkr-code mannequin commented Mar 12, 2020

comment:7

Reviewer Name: Divesh Kumar was missing in the previous review. Has been added.

@kcrisman
Copy link
Member

comment:8

What they meant was to put this in the box provided. See what changed at this revision.

@kcrisman
Copy link
Member

Reviewer: Divesh Kumar

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Mar 12, 2020

Changed author from gh-unicorn-io to Vishesh Tayal

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Mar 12, 2020

comment:9

Name from https://github.com/unicorn-io

@vbraun
Copy link
Member

vbraun commented Mar 14, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants