Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickle cached value of volume and f-vector #29223

Closed
kliem opened this issue Feb 20, 2020 · 9 comments
Closed

Pickle cached value of volume and f-vector #29223

kliem opened this issue Feb 20, 2020 · 9 comments

Comments

@kliem
Copy link
Contributor

kliem commented Feb 20, 2020

Volume, f-vector and Ehrhart polynomial of polyhedra can be hard to compute, but take little memory when saving.

So we pickle those values, e.g.

+    @cached_method(do_pickle=True)
-    @cached_method
     def f_vector(self):

CC: @jplab @LaisRast

Component: geometry

Keywords: polyhedron, volume, f_vector

Author: Jonathan Kliem

Branch/Commit: cd13c82

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/29223

@kliem kliem added this to the sage-9.1 milestone Feb 20, 2020
@kliem
Copy link
Contributor Author

kliem commented Feb 21, 2020

Author: Jonathan Kliem

@kliem
Copy link
Contributor Author

kliem commented Feb 21, 2020

Branch: public/29223

@kliem
Copy link
Contributor Author

kliem commented Feb 21, 2020

New commits:

f28363dpickle cache of volume, f_vector, ehrhart polynomial
cd13c82typo

@kliem

This comment has been minimized.

@kliem
Copy link
Contributor Author

kliem commented Feb 21, 2020

Commit: cd13c82

@LaisRast
Copy link

Reviewer: Laith Rastanawi

@LaisRast
Copy link

comment:2

It looks good to me.
Is there a reason why you did not do the same for functions of CombinatorialPolyhedron?

@kliem
Copy link
Contributor Author

kliem commented Feb 28, 2020

comment:3

Yes, CombinatorialPolyhedron doesn't exactly pickle. It just reduces, i.e. save enough data to initialize the object again. At some point one could think about a better way of pickling, of course.

@vbraun
Copy link
Member

vbraun commented Mar 1, 2020

Changed branch from public/29223 to cd13c82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants