Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 optional internet oeis doctest failing in combinat/tutorial.py #29237

Closed
seblabbe opened this issue Feb 23, 2020 · 8 comments
Closed

1 optional internet oeis doctest failing in combinat/tutorial.py #29237

seblabbe opened this issue Feb 23, 2020 · 8 comments

Comments

@seblabbe
Copy link
Contributor

With 9.1.beta5:

sage -t --optional=sage,internet src/sage/combinat/tutorial.py
**********************************************************************
File "src/sage/combinat/tutorial.py", line 1732, in sage.combinat.tutorial
Failed example:
    oeis(L)                                       # optional -- internet
Expected:
    0: A000045: Fibonacci numbers: F(n) = F(n-1) + F(n-2) with F(0) = 0 and F(1) = 1.
    1: A212804: Expansion of (1-x)/(1-x-x^2).
    2: A132636: a(n) = Fibonacci(n) mod n^3.
Got:
    0: A000045: Fibonacci numbers: F(n) = F(n-1) + F(n-2) with F(0) = 0 and F(1) = 1.
    1: A212804: Expansion of (1-x)/(1-x-x^2).
    2: A324969: Number of unlabeled rooted identity trees with n vertices whose non-leaf terminal subtrees are all different.
**********************************************************************
1 item had failures:
   1 of 245 in sage.combinat.tutorial
    [244 tests, 1 failure, 7.22 s]
----------------------------------------------------------------------
sage -t src/sage/combinat/tutorial.py  # 1 doctest failed
----------------------------------------------------------------------

CC: @sagetrac-tmonteil @tscrim @jm58660

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 91664c6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29237

@seblabbe seblabbe added this to the sage-9.1 milestone Feb 23, 2020
@fchapoton
Copy link
Contributor

comment:2

here it is, please review


New commits:

91664c6fix oeis doctest in tutorial

@fchapoton
Copy link
Contributor

Commit: 91664c6

@fchapoton
Copy link
Contributor

Branch: u/chapoton/29237

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

easy one, please review

@tscrim
Copy link
Collaborator

tscrim commented Mar 5, 2020

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Mar 5, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Mar 8, 2020

Changed branch from u/chapoton/29237 to 91664c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants