Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a bunch of details in doc #29239

Closed
fchapoton opened this issue Feb 23, 2020 · 9 comments
Closed

a bunch of details in doc #29239

fchapoton opened this issue Feb 23, 2020 · 9 comments
Labels
c: documentation p: major / 3 t: enhancement
Milestone
sage-9.1

Comments

@fchapoton
Copy link
Contributor

mainly

  • adding missing empty lines

  • remove # comments in the doctests

  • add missing ... lines in Traceback tests

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 975f54c

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29239
@fchapoton fchapoton added this to the sage-9.1 milestone Feb 23, 2020
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/29239

@fchapoton
Copy link
Contributor Author

Commit: 002b58a

@fchapoton
Copy link
Contributor Author

New commits:

002b58aa bunch of tiny details in the doc (missing ... and empty lines)

@tscrim
Copy link
Collaborator

tscrim commented Feb 24, 2020

comment:2

Super nitpick, but

-Let us use spherical coordinates on R^3::
+Let us use spherical coordinates on `\RR^3`::

Thank you for your work in improving the doc.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

975f54ctrac 29239 fix some details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2020

Changed commit from 002b58a to 975f54c

@tscrim
Copy link
Collaborator

tscrim commented Feb 25, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 25, 2020

comment:4

Thank you.

@vbraun
Copy link
Member

vbraun commented Feb 26, 2020

Changed branch from u/chapoton/29239 to 975f54c

@vbraun vbraun closed this as completed in edb7d1c Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton