New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CombinatorialPolyhedron: bit_repr_
-> bit_rep_
#29242
Comments
Commit: |
Branch: public/29242 |
comment:2
The reason I missed it is simple: autoreplacement. When changing back |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
Once #29190 is done, I will put this on "positive review" |
Reviewer: Laith Rastanawi |
comment:7
Merge conflict. |
Changed branch from public/29242 to public/29242-reb |
Changed branch from public/29242-reb to |
This is a follow up on #28608.
It turns out we missed the case
bit_repr_
.In order to be consistent, we change this to
bit_rep_
(at the moment there are both versions in use).Even though those 4 python functions in
conversions.pyx
are very unlikely to be used elsewhere, we add deprecation warnings according to the name those 4 functions had before #28608.Depends on #29190
CC: @jplab @LaisRast
Component: geometry
Author: Jonathan Kliem
Branch/Commit:
0f38cbe
Reviewer: Laith Rastanawi
Issue created by migration from https://trac.sagemath.org/ticket/29242
The text was updated successfully, but these errors were encountered: