Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombinatorialPolyhedron: bit_repr_ -> bit_rep_ #29242

Closed
kliem opened this issue Feb 24, 2020 · 14 comments
Closed

CombinatorialPolyhedron: bit_repr_ -> bit_rep_ #29242

kliem opened this issue Feb 24, 2020 · 14 comments

Comments

@kliem
Copy link
Contributor

kliem commented Feb 24, 2020

This is a follow up on #28608.

It turns out we missed the case bit_repr_.

In order to be consistent, we change this to bit_rep_ (at the moment there are both versions in use).

Even though those 4 python functions in conversions.pyx are very unlikely to be used elsewhere, we add deprecation warnings according to the name those 4 functions had before #28608.

Depends on #29190

CC: @jplab @LaisRast

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 0f38cbe

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/29242

@kliem kliem added this to the sage-9.1 milestone Feb 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Feb 24, 2020

Commit: 2c255ab

@kliem
Copy link
Contributor Author

kliem commented Feb 24, 2020

Branch: public/29242

@kliem
Copy link
Contributor Author

kliem commented Feb 24, 2020

New commits:

328c16dcopy for ListOfFaces
8beef7cadd polar for combinatorial polyhedron
2c255ab_bit_repr_ -> _bit_rep_

@kliem
Copy link
Contributor Author

kliem commented Feb 24, 2020

comment:2

The reason I missed it is simple: autoreplacement.

When changing back def _repr_(self) I mistakenly also changed bit_rep_ to _bit_repr_ again.

@kliem

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 28, 2020

Changed commit from 2c255ab to 1c7f1b2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 28, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

1c7f1b2corrected ticket number

@LaisRast
Copy link

comment:5

Once #29190 is done, I will put this on "positive review"

@LaisRast
Copy link

Reviewer: Laith Rastanawi

@kliem
Copy link
Contributor Author

kliem commented Mar 27, 2020

comment:7

Merge conflict.

@kliem
Copy link
Contributor Author

kliem commented Mar 27, 2020

Changed commit from 1c7f1b2 to 0f38cbe

@kliem
Copy link
Contributor Author

kliem commented Mar 27, 2020

Changed branch from public/29242 to public/29242-reb

@kliem
Copy link
Contributor Author

kliem commented Mar 27, 2020

comment:8

Sorry, had to rebase it to the current branch of #29190.


New commits:

23b87edcopy for ListOfFaces
309150badd polar for combinatorial polyhedron
586bc82renamed polar to dual
73cf39ffixing doctest
de0238a_bit_repr_ -> _bit_rep_
0f38cbecorrected ticket number

@vbraun
Copy link
Member

vbraun commented Apr 5, 2020

Changed branch from public/29242-reb to 0f38cbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants