Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of easy cases in lift_to_sl2z() #29246

Closed
pjbruin opened this issue Feb 26, 2020 · 6 comments
Closed

Improve handling of easy cases in lift_to_sl2z() #29246

pjbruin opened this issue Feb 26, 2020 · 6 comments

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Feb 26, 2020

The function lift_to_sl2z(c, d, N) returns larger coefficients than needed in the cases c = 0 or d = 0. Also, the (trivial) case N = 1 is not treated correctly.

Before:

sage: lift_to_sl2z(0, 41, 42)
[-1, -2, 42, 83]
sage: lift_to_sl2z(0, 5, 42)
[17, 19, 42, 47]
sage: lift_to_sl2z(5, 0, 42)
[-2, -101, 5, 252]
sage: lift_to_sl2z(0, 0, 1)
Traceback (most recent call last):
...
AttributeError: Element (0, 0) not in P1.

After:

sage: lift_to_sl2z(0, 41, 42)
[-1, 0, 0, -1]
sage: lift_to_sl2z(0, 5, 42)
[17, 2, 42, 5]
sage: lift_to_sl2z(5, 0, 42)
[-2, -17, 5, 42]
sage: lift_to_sl2z(0, 0, 1)
[1, 0, 0, 1]

Component: modular forms

Author: Peter Bruin

Branch/Commit: bcc2c19

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/29246

@pjbruin pjbruin added this to the sage-9.1 milestone Feb 26, 2020
@pjbruin
Copy link
Contributor Author

pjbruin commented Feb 26, 2020

Branch: u/pbruin/29246-lift_to_sl2z

@pjbruin
Copy link
Contributor Author

pjbruin commented Feb 26, 2020

Commit: bcc2c19

@mkoeppe
Copy link
Member

mkoeppe commented Apr 14, 2020

comment:2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@fchapoton
Copy link
Contributor

comment:4

ok, let it be

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Nov 7, 2020

Changed branch from u/pbruin/29246-lift_to_sl2z to bcc2c19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants