Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair cython_aliases ARB_LIBRARY #29305

Closed
mkoeppe opened this issue Mar 9, 2020 · 16 comments
Closed

Repair cython_aliases ARB_LIBRARY #29305

mkoeppe opened this issue Mar 9, 2020 · 16 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 9, 2020

It was moved from sage-env-config to sage-build-env-config. However it is used in cython_aliases, as reported in https://groups.google.com/d/msg/sage-devel/lMDRg3OJtl4/zU-AQNZwAQAJ, which user packages may be using.

CC: @dimpase @mezzarobba

Component: build

Author: Matthias Koeppe

Branch/Commit: dcd755a

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29305

@mkoeppe mkoeppe added this to the sage-9.1 milestone Mar 9, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 9, 2020

comment:1

But actually I think a better solution than cython_aliases needs to be found in the longer term. Installed .pxd headers should be made usable without a special environment.

@orlitzky
Copy link
Contributor

orlitzky commented Mar 9, 2020

comment:2

Replying to @mkoeppe:

But actually I think a better solution than cython_aliases needs to be found in the longer term. Installed .pxd headers should be made usable without a special environment.

Yeah, most of what cython_aliases does is run pkg-config for you. I think the standard cython build tools allow you to do that manually if you want, but what's missing is a way to easily get e.g. all of the flags that sage itself used. Probably sagelib needs a *.pc file at some point, and you could just gets the libs/include-dirs from that.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Move ARB_LIBRARY back from sage-build-env-config to sage-env-config Repair cython_aliases ARB_LIBRARY Mar 9, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 9, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 9, 2020

Commit: be3c581

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 9, 2020

New commits:

be3c581Configure ARB_LIBRARY through sage_conf

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 9, 2020

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Mar 9, 2020

comment:6

funny spacing:

+var('ARB_LIBRARY',                   'arb')

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 9, 2020

comment:7

It aligns with lines above

@dimpase
Copy link
Member

dimpase commented Mar 9, 2020

comment:8

align at least the line directly above it too, then.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

dcd755acosmetic change

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 9, 2020

Changed commit from be3c581 to dcd755a

@dimpase
Copy link
Member

dimpase commented Mar 9, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Mar 9, 2020

comment:10

OK

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 9, 2020

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants