Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise the unit element in new_CRing #29311

Closed
pjbruin opened this issue Mar 11, 2020 · 7 comments
Closed

Initialise the unit element in new_CRing #29311

pjbruin opened this issue Mar 11, 2020 · 7 comments

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Mar 11, 2020

Reported by Markus Wageringel in #29247 comment:14:

sage: R.<x,y,z> = QQ[]
sage: from sage.libs.singular.function_factory import ff
sage: W = ff.ring(ff.ringlist(R), ring=R)
sage: C = sage.rings.polynomial.plural.new_CRing(W, R.base_ring())
sage: C.one()   # should be 1
0

CC: @mwageringel @tscrim

Component: coercion

Author: Peter Bruin

Branch/Commit: 799cf55

Reviewer: Travis Scrimshaw, Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/29311

@pjbruin pjbruin added this to the sage-9.1 milestone Mar 11, 2020
@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 11, 2020

Branch: u/pbruin/29311-new_CRing

@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 11, 2020

Commit: cd3524d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2020

Changed commit from cd3524d to 799cf55

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

799cf55Trac 29311: initialise the unit element in new_CRing

@mwageringel
Copy link

comment:3

Thank you for fixing this so quickly. I can confirm that this also resolves the problem that came up in #25993.

I will add Travis to the reviewers, as he was positive about this approach.

@mwageringel
Copy link

Reviewer: Travis Scrimshaw, Markus Wageringel

@vbraun
Copy link
Member

vbraun commented Mar 12, 2020

Changed branch from u/pbruin/29311-new_CRing to 799cf55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants