Algorithm run time and implementation

[surajkrmodi]

I have included an experimental package for sagemath
and package of graph diameter has been successfully installed

Component: graph theory

Keywords: Diameter

Branch/Commit: u/gh-surajkrmodi/algorithm_run_time_and_implementation @ df8b76f

Issue created by migration from https://trac.sagemath.org/ticket/29336

[surajkrmodi]

Changed keywords from none to Diameter

[surajkrmodi]

Branch: u/gh-surajkrmodi/algorithm_run_time_and_implementation

[dcoudert]

comment:3

This is not the right direction. If I understand well, you have copy/paste the code of Yuki Kawata, and do various edits in different files.

I you want to use the code of Yuki Kawata, you can propose an interface to this code and make it an optional package of Sagemath (at first an experimental package). See the developper manual.

---

New commits:

b607344

First commit

[dcoudert]

Commit: b607344

[sagetrac-git]

Changed commit from b607344 to f5d36fd

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f5d36fd

On branch t/29336/algorithm_run_time_and_implementation

[sagetrac-git]

Changed commit from f5d36fd to 533c7a4

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

533c7a4

deleted: sample/lol.tsv

[sagetrac-git]

Changed commit from 533c7a4 to 8306b28

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8306b28

deleted: myscript.py

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

29d11ec

modified: src/sage/graphs/bipartite_graph.py

[sagetrac-git]

Changed commit from 8306b28 to 29d11ec

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

391d37a

new file: build/pkgs/graphdiameter/SPKG.txt

[sagetrac-git]

Changed commit from 29d11ec to 391d37a

[surajkrmodi]

comment:10

error i got while running sage --package
sage-run received unknown option: --package
usage: sage [options]
Try 'sage -h' for more information.

[sagetrac-git]

Changed commit from 391d37a to 68139bc

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

68139bc

modified: build/pkgs/graphdiameter/checksums.ini

[sagetrac-git]

Changed commit from 68139bc to 7d22f27

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7d22f27

modified: build/pkgs/graphdiameter/spkg-install

[surajkrmodi]

comment:13

waiting for review and further instructions

[sagetrac-git]

Changed commit from 7d22f27 to df8b76f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

df8b76f

modified: build/pkgs/graphdiameter/SPKG.txt

[dcoudert]

comment:15

I don't have the expertise to check if this is the right way to make an experimental package. I will call for help.
Meanwhile, where can I find the tarball ?

[mkoeppe]

comment:16

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

[seblabbe]

comment:17

Information how to make a new package is here: https://doc.sagemath.org/html/en/developer/packaging.html

Note that a new feature is to provide the upstream_url directly in the checksums file, see for instance #30342.

Because the upstream url is not provided, I change the status to needs work.

[seblabbe]

comment:18

Also it seems the branch is doing a chmod change to the file src/sage/graphs/centrality.pyx which is weird.

[mkoeppe]

comment:20

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

[dcoudert]

comment:21

May be it's time to move this ticket to wontfix.

[mkoeppe]

comment:22

Setting a new milestone for this ticket based on a cursory review.