New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parent of q-Catalan numbers #29353
Comments
Commit: |
New commits:
|
Branch: u/chapoton/29353 |
Reviewer: Travis Scrimshaw |
comment:2
Two questions: On a similar but technically unrelated issue: What about Is Otherwise LGTM. |
comment:3
Containment in sets seems to be faster (but I am not so sure):
I will take care of the q_factorial case too. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
I found that page about containment in sets |
comment:6
Containment in sets is definitely faster, but you also have to create the set every time. Now that I am in front my computer, I can test this:
Surprisingly, tuples are the most optimized:
Not that this matters too much, but just a question I had because it is not something I had seen before. You can set it to a positive review if you don't care enough to change it. I don't care either way. Sorry, I missed the parent test for Thank you for fixing these bugs. |
comment:7
ok, setting to positive. Thanks for the review |
Changed branch from u/chapoton/29353 to |
at n=0 and n=1
plus some pep8 details in the modified file
Component: combinatorics
Author: Frédéric Chapoton
Branch/Commit:
045fbe6
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/29353
The text was updated successfully, but these errors were encountered: