gf2x build fails on fedora-32-minimal

[mkoeppe]

https://github.com/mkoeppe/sage/runs/524868611

libtool: link: gcc -O2 -g -Wall -W -msse2 -msse3 -mssse3 -msse4.1 -mpclmul -Wl,-rpath -Wl,/sage/local/lib -o tunetoom tunetoom.o tuning-common.o  -L/sage/local/lib ./.libs/libtiming.a ../.libs/libgf2x.so -lm -Wl,-rpath -Wl,/sage/local/var/tmp/sage/build/gf2x-1.2.p0/src/.libs -Wl,-rpath -Wl,/sage/local/lib
/usr/bin/ld: tuning-common.o:(.bss+0x8): multiple definition of `rp'; tunetoom.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status

CC: @dimpase

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 7693ede

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/29390

[orlitzky]

Attachment: 0001-src-tunetoom.c-delete-duplicate-definition-of-rp.patch.gz

[orlitzky]

comment:2

I sent this patch (against git HEAD) upstream. It does the job here.

[orlitzky]

comment:3

My patch was merged upstream already (on top of gf2x-1.3.0, which has been out for a few months). There shouldn't be any problem applying it to v1.2 even if that one line I deleted has moved.

[mkoeppe]

Branch: u/mkoeppe/gf2x_build_fails_on_fedora_32_minimal

[mkoeppe]

comment:6

Thanks, the patch applies cleanly

---

New commits:

7693ede

Add build/pkgs/gf2x/patches/0001-src-tunetoom.c-delete-duplicate-definition-of-rp.patch

[mkoeppe]

Commit: 7693ede

[mkoeppe]

Author: Matthias Koeppe

[orlitzky]

Reviewer: Michael Orlitzky

[orlitzky]

comment:8

It works with CFLAGS="-fno-common", so good enough?

[mkoeppe]

comment:9

I haven't tested it widely. Any thoughts?

[mkoeppe]

comment:11

Tests now run at https://github.com/mkoeppe/sage/actions/runs/88544669

[orlitzky]

comment:12

It's an obviously-correct one-line change to the custom tuning code -- not even to gf2x itself -- so I'm sure the change is OK. It's up to you if you actually want to try it on fedora-32, though, given the subject of the ticket.

[mkoeppe]

comment:13

Thanks. I'll set this back to 9.1 when it has passed the test.

[mkoeppe]

comment:14

OK, looking great.

[vbraun]

Changed branch from u/mkoeppe/gf2x_build_fails_on_fedora_32_minimal to 7693ede