New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing doctest in src/sage/interfaces/tachyon.py #29442
Comments
New commits:
|
Commit: |
Branch: public/29442 |
This comment has been minimized.
This comment has been minimized.
Reviewer: Frédéric Chapoton |
comment:2
ok, thanks |
comment:3
I should have double checked.
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
I don't think doctest results starting with "..." work because they are mistaken for continuation prompts.
|
comment:7
Ok. Now, I'm testing internally the following and it seems it passes:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:10
This seems to work now https://github.com/kliem/sage-test-27122/actions/runs/70559675 There are many clean runs now. |
This comment has been minimized.
This comment has been minimized.
Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Matthias Koeppe |
comment:12
Looks good to me. |
Changed branch from public/29442 to |
This seems to have been introduced by using the systems tachyon. It appears that in some cases (depending on the version probably) tachyon does not print out the first lines
We fix this by testing for the following output:
CC: @mkoeppe
Component: interfaces
Keywords: tachyon
Author: Jonathan Kliem
Branch/Commit:
871df4b
Reviewer: Frédéric Chapoton, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/29442
The text was updated successfully, but these errors were encountered: