Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade matplotlib to 2.2.5 (last release supporting py2) #29444

Closed
mkoeppe opened this issue Apr 1, 2020 · 14 comments
Closed

Upgrade matplotlib to 2.2.5 (last release supporting py2) #29444

mkoeppe opened this issue Apr 1, 2020 · 14 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 1, 2020

Previous updates:

CC: @antonio-rojas @kiwifb @timokau @infinity0 @kcrisman @saraedum @slel @tobihan @dimpase @jdemeyer @embray @kliem

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: a92d874

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29444

@mkoeppe mkoeppe added this to the sage-9.1 milestone Apr 1, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 1, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 1, 2020

Commit: d62b669

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 1, 2020

New commits:

d62b669Update matplotlib to 2.2.5, remove patches

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 1, 2020

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Apr 3, 2020

comment:5
--- a/build/pkgs/matplotlib/checksums.ini
+++ b/build/pkgs/matplotlib/checksums.ini
@@ -1,4 +1,4 @@
-tarball=matplotlib-VERSION.tar.bz2
+tarball=matplotlib-VERSION.tar.gz
 sha1=fdb01bd4b35a0947e0b10b4a349d32dca305d7fd
 md5=422fc58e7323b7ba3f19382424f9ab7b
 cksum=2814562579

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 8, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

a92d874gz, not bz2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 8, 2020

Changed commit from d62b669 to a92d874

@kliem
Copy link
Contributor

kliem commented Apr 10, 2020

comment:8

I tested this upgrade on debian buster and all tests passed (sage -t --long -all), except for one that has nothing to do with this ticket:

sage -t --long src/sage/env.py
**********************************************************************
File "src/sage/env.py", line 15, in sage.env
Failed example:
    out == repr((SAGE_ROOT, SAGE_LOCAL))                                        # long time
Expected:
    True
Got:
    False

(I have something set up with a symlink and the test doesn't test equal, even though it is de facto the same location, probably incorrect setup but irrelevant here.)

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 11, 2020

comment:9

Replying to @kliem:

I tested this upgrade on debian buster and all tests passed (sage -t --long -all),

I've also been running tests with it for a while now. Let's just get it in.

except for one that has nothing to do with this ticket

(that's #29446, just cosmetic)

@dimpase
Copy link
Member

dimpase commented Apr 12, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Apr 12, 2020

comment:10

ok

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 12, 2020

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Apr 16, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants