Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickling Frobenius endomorphism is broken #29452

Closed
xcaruso opened this issue Apr 2, 2020 · 11 comments
Closed

Pickling Frobenius endomorphism is broken #29452

xcaruso opened this issue Apr 2, 2020 · 11 comments

Comments

@xcaruso
Copy link
Contributor

xcaruso commented Apr 2, 2020

sage: k.<a> = GF(5^3)
sage: Frob = k.frobenius_endomorphism()
sage: Frob
Frobenius endomorphism a |--> a^5 on Finite Field in a of size 5^3
sage: loads(dumps(Frob))
Identity endomorphism of Finite Field in a of size 5^3

Component: finite rings

Author: Xavier Caruso

Branch/Commit: 16ce9e3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29452

@xcaruso xcaruso added this to the sage-9.1 milestone Apr 2, 2020
@xcaruso
Copy link
Contributor Author

xcaruso commented Apr 2, 2020

Branch: u/caruso/pickling_frobenius

@xcaruso
Copy link
Contributor Author

xcaruso commented Apr 2, 2020

comment:2

Here is a fix.


New commits:

8f40b0afix pickling for Frobenius endomorphisms

@xcaruso
Copy link
Contributor Author

xcaruso commented Apr 2, 2020

Commit: 8f40b0a

@xcaruso
Copy link
Contributor Author

xcaruso commented Apr 2, 2020

Author: Xavier Caruso

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2020

Changed commit from 8f40b0a to cb588b8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

cb588b8fix pickling for embeddings

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

16ce9e3add testsuite

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2020

Changed commit from cb588b8 to 16ce9e3

@tscrim
Copy link
Collaborator

tscrim commented Apr 3, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 3, 2020

comment:5

Indeed the domain should always be finite since it is a finite field morphism. LGTM.

@vbraun
Copy link
Member

vbraun commented Apr 9, 2020

Changed branch from u/caruso/pickling_frobenius to 16ce9e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants