Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker images generated by GitHub CI workflows available; minor CI fixes #29530

Closed
mkoeppe opened this issue Apr 18, 2020 · 42 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 18, 2020

They are already tagged with meaningful names and just need to be pushed to a registry.

Now we push them to the registry provided by GitHub.
Example: https://github.com/mkoeppe/sage/runs/604103405 created https://github.com/mkoeppe/sage/packages/193111

Depends on #29341
Depends on #29534

CC: @kliem @vbraun @dimpase @embray @saraedum @slel

Component: porting

Keywords: ci, ContinuousIntegration

Author: Matthias Koeppe

Branch/Commit: 163562d

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29530

@mkoeppe mkoeppe added this to the sage-9.1 milestone Apr 18, 2020
@slel
Copy link
Member

slel commented Apr 18, 2020

Changed keywords from none to ci

@slel slel added the c: docker label Apr 18, 2020
@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Apr 19, 2020

comment:3

will it be possible to pull an image for letting cal inspection and debugging? cool.
(currently building a fedora 28 image locally...)

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 19, 2020

Dependencies: #29341

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 20, 2020

Changed keywords from ci to ci, ContinuousIntegration

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 20, 2020

Changed dependencies from #29341 to #29341, #29534

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 20, 2020

comment:7

Replying to @dimpase:

will it be possible to pull an image for ... inspection and debugging?

Yes, that's the idea

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 21, 2020

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

e506503Add documentation
d6b64batox-optional.yml: Push the docker images

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2020

Commit: d6b64ba

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 21, 2020

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2020

Changed commit from d6b64ba to 06a9c39

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

06a9c39fixup doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2020

Changed commit from 06a9c39 to 02f86f6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

02f86f6tox*.yml: First try secrets.DOCKER_PKG_GITHUB_TOKEN, then secrets.GITHUB_TOKEN; ignore errors

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

00a82b0Merge tag '9.1.rc1' into t/29530/make_docker_images_generated_by_github_ci_workflows_available
807c2bdFix spelling of --downloadonly
bd687c9Merge branch 't/29403/ci_cygwin_yml__multi_stage_build' into t/29341/optional-test-9.1.rc0
784abe8ci-cygwin.yml: SAGE_FAT_BINARY=yes
eeadb9d.github/workflows/ci-cygwin.yml: Test more optional packages
316c5f6Fixup
37c2186Merge branch 't/29341/optional-test-9.1.rc0' into t/29530/make_docker_images_generated_by_github_ci_workflows_available

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2020

Changed commit from 02f86f6 to 37c2186

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

87210e9.github/workflows/ci-cygwin.yml: Rebalance stages
0d886ccbuild/pkgs/pari_nftables/distros/arch.txt: Remove (package does not exist)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2020

Changed commit from 37c2186 to 0d886cc

@mkoeppe mkoeppe changed the title Make Docker images generated by GitHub CI workflows available Make Docker images generated by GitHub CI workflows available; minor CI fixes Apr 23, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

652787b.github/workflows/tox*.yml: Make copying logs from containers more robust

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2020

Changed commit from 0d886cc to 652787b

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 24, 2020

comment:17

copying logs needs more work, e.g. https://github.com/mkoeppe/sage/runs/612694530?check_suite_focus=true displays no logs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

2b9f531local-{conda,homebrew}-maximal: Take packages from -standard

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 652787b to 2b9f531

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 2b9f531 to 88b5aa6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

88b5aa6tox.ini: Commit a failed build container so that logs are copied from it

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 88b5aa6 to f8c6e7a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f8c6e7atox.ini: Commit a failed build container so that logs are copied from it

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from f8c6e7a to 4f4fe60

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

5c8e685tox-optional.yml: Fix likewise
4f4fe60ci-cygwin.yml: Split the file so that unrelated stages do not wait

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

27c63f1Improve docker login instructions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 4f4fe60 to 27c63f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

dbf461dMerge tag '9.1.rc2' into t/29530/make_docker_images_generated_by_github_ci_workflows_available

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 27c63f1 to dbf461d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from dbf461d to 163562d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

163562dRename cygwin workflows

@dimpase
Copy link
Member

dimpase commented Apr 26, 2020

comment:26

OK, this looks nice now. I have tested just one docker image, but I trust this should be fine in general.

@dimpase
Copy link
Member

dimpase commented Apr 26, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2020

comment:27

Thank you!

@vbraun
Copy link
Member

vbraun commented May 2, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants