Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix buggy test in #29445 #29554

Closed
dimpase opened this issue Apr 23, 2020 · 20 comments
Closed

fix buggy test in #29445 #29554

dimpase opened this issue Apr 23, 2020 · 20 comments

Comments

@dimpase
Copy link
Member

dimpase commented Apr 23, 2020

configure:17249: checking whether hyperellcharpoly bug is fixed
  ***   too many arguments: ...lcharpoly(x^10+x^9+x^8+x,0*Mod(1,3))
  ***                                                   ^-----------
configure:17257: result: no; cannot use system pari/GP with known bug

also should fix the error in another ticket #29494 touching this stuff

CC: @mkoeppe @kliem @fchapoton @videlec @kedlaya

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: bf8c1d9

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/29554

@dimpase dimpase added this to the sage-9.1 milestone Apr 23, 2020
@dimpase
Copy link
Member Author

dimpase commented Apr 23, 2020

comment:1
{{{
configure:17249: checking whether hyperellcharpoly bug is fixed
  ***   too many arguments: ...lcharpoly(x^10+x^9+x^8+x,0*Mod(1,3))
  ***                                                   ^-----------
configure:17257: result: no; cannot use system pari/GP with known bug

}}}

@dimpase
Copy link
Member Author

dimpase commented Apr 23, 2020

comment:2

missing extra pair of []:

-        bug_check=$(echo "hyperellcharpoly([x^10 + x^9 + x^8 + x,0]*Mod(1,3))" | $GP -qf 2>> config.log)
+        bug_check=`echo "hyperellcharpoly([[x^10 + x^9 + x^8 + x,0]]*Mod(1,3))" | $GP -qf 2>> config.log`

@dimpase

This comment has been minimized.

@dimpase

This comment has been minimized.

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented Apr 23, 2020

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Apr 23, 2020

Branch: u/dimpase/packages/parifixes

@dimpase
Copy link
Member Author

dimpase commented Apr 23, 2020

Commit: 526d15c

@dimpase
Copy link
Member Author

dimpase commented Apr 23, 2020

New commits:

526d15cfix buggy tests in #29445 and in #29494

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2020

Changed commit from 526d15c to bf8c1d9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

bf8c1d9use macro to check pari/gp deps

@videlec
Copy link
Contributor

videlec commented Apr 23, 2020

Attachment: config.log

@videlec
Copy link
Contributor

videlec commented Apr 23, 2020

comment:9

configure is now happy with my pari. However there is something that I don't understand in config.log line 2023. matpermanent is not found. Why is there a search for it if it does not matter?

@dimpase
Copy link
Member Author

dimpase commented Apr 23, 2020

comment:10

Replying to @videlec:

configure is now happy with my pari. However there is something that I don't understand in config.log line 2023. matpermanent is not found. Why is there a search for it if it does not matter?

This is normal functioning of AC_SEARCH_LIBS macro.

matpermanent is used to detect that libpari is at least verision 2.11. First, an attempt is made to link without -lpari, adn it fails. The next attempt (line 2107), -lpari is added, and test passes.

@videlec
Copy link
Contributor

videlec commented Apr 23, 2020

comment:11

If you feel like testing on my computer was good enough for a review, you can set to positive review.

@videlec
Copy link
Contributor

videlec commented Apr 23, 2020

Reviewer: Vincent Delecroix

@dimpase
Copy link
Member Author

dimpase commented Apr 23, 2020

comment:12

Thanks, I think it's good.

@kliem
Copy link
Contributor

kliem commented Apr 23, 2020

comment:13

Thanks for the quick fix.

I started test runs a minute ago: https://github.com/kliem/sage-test-27122/actions/runs/85835472.

I will leave a message here tomorrow either way, but I don't expect any trouble.

@kliem
Copy link
Contributor

kliem commented Apr 24, 2020

comment:14

Replying to @kliem:

Thanks for the quick fix.

I started test runs a minute ago: https://github.com/kliem/sage-test-27122/actions/runs/85835472.

I will leave a message here tomorrow either way, but I don't expect any trouble.

Yes. Seems to work fine.

@vbraun
Copy link
Member

vbraun commented Apr 24, 2020

Changed branch from u/dimpase/packages/parifixes to bf8c1d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants