Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some details suggested by lgtm in number fields and quaternions #29564

Closed
fchapoton opened this issue Apr 24, 2020 · 9 comments
Closed

fix some details suggested by lgtm in number fields and quaternions #29564

fchapoton opened this issue Apr 24, 2020 · 9 comments
Labels
c: number fields p: minor / 4 t: enhancement
Milestone
sage-9.1

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: number fields

Author: Frédéric Chapoton

Branch/Commit: d425680

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29564
@fchapoton fchapoton added this to the sage-9.2 milestone Apr 24, 2020
@fchapoton
Copy link
Contributor Author

Commit: 24d78d1

@fchapoton
Copy link
Contributor Author

New commits:

24d78d1some lgtm-suggested details in number fields and quaternions

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/29564

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 24, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

d425680details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 24, 2020

Changed commit from 24d78d1 to d425680

@fchapoton
Copy link
Contributor Author

comment:3

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Apr 24, 2020

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Apr 24, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Apr 26, 2020

Changed branch from u/chapoton/29564 to d425680

@vbraun vbraun closed this as completed in f927058 Apr 26, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.1 May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: number fields p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @mkoeppe