Don't override LDFLAGS in m4rie

[isuruf]

https://bitbucket.org/malb/m4rie/pull-requests/4/do-not-interfere-with-ldflags-while

Upstream: Fixed upstream, but not in a stable release.

CC: @mkoeppe

Component: packages: standard

Author: Isuru Fernando

Branch/Commit: cebd333

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29597

[mkoeppe]

comment:2

This one won't work as is - need to patch Makefile.in as well

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

64dc437

Fix m4rie's tests/Makefile.in

[sagetrac-git]

Changed commit from 1fb29e6 to 64dc437

[mkoeppe]

comment:4

Thanks!

[mkoeppe]

Reviewer: Matthias Koeppe

[mkoeppe]

comment:6

This seems to break other platforms - https://github.com/mkoeppe/sage/actions/runs/88768093

[isuruf]

comment:7

Looks like the patch failed to apply

[sagetrac-git]

Changed commit from 64dc437 to cc0453b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cc0453b

Update patch for m4rie

[mkoeppe]

comment:10

Let me try

[mkoeppe]

comment:11

Hm... doesn't the release that we use already have this patch in?

[mkoeppe]

comment:12

https://github.com/mkoeppe/sage/runs/623414296

m4rie-20200115
====================================================
Setting up build directory for m4rie-20200115
Finished extraction
Applying patches from ../patches...
Applying ../patches/use_AM_LDLFAGS.patch
patching file Makefile.am
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file Makefile.am.rej
patching file Makefile.in
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file Makefile.in.rej
Error applying '../patches/use_AM_LDLFAGS.patch'
************************************************************************

[mkoeppe]

comment:14

Something indeed needs fixing

[mkoeppe]

Changed branch from u/isuruf/m4rie_ldflags to u/mkoeppe/m4rie_ldflags

[mkoeppe]

Changed branch from u/mkoeppe/m4rie_ldflags to u/isuruf/m4rie_ldflags

[mkoeppe]

comment:16

Squashed

[mkoeppe]

Changed branch from u/isuruf/m4rie_ldflags to u/mkoeppe/m4rie_ldflags

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cebd333

Fixup m4rie patch

[sagetrac-git]

Changed commit from cc0453b to cebd333

[mkoeppe]

comment:20

OK now it works!

[vbraun]

Changed branch from u/mkoeppe/m4rie_ldflags to cebd333