Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix singular configure patch #29601

Closed
isuruf opened this issue Apr 27, 2020 · 4 comments
Closed

Fix singular configure patch #29601

isuruf opened this issue Apr 27, 2020 · 4 comments
Labels
c: build p: critical / 2 t: bug
Milestone
sage-9.1

Comments

@isuruf
Copy link
Member

isuruf commented Apr 27, 2020

Follow-up from #29335:

The patch was incomplete and this ticket fixes it

CC: @mkoeppe

Component: build

Author: Isuru Fernando

Branch/Commit: 840b1d3

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29601
@isuruf isuruf added this to the sage-9.1 milestone Apr 27, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Apr 27, 2020

Reviewer: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member

mkoeppe commented Apr 28, 2020

comment:3

I have some trouble with singular on my test branch that includes this ticket - on homebrew ​https://github.com/mkoeppe/sage/runs/624792671

@vbraun
Copy link
Member

vbraun commented May 4, 2020

Changed branch from u/isuruf/singular_configure to 840b1d3

@vbraun vbraun closed this as completed in d92d65d May 4, 2020
@isuruf isuruf mentioned this issue Apr 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @isuruf @mkoeppe