Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong self import in skew polynomials #29603

Closed
fchapoton opened this issue Apr 27, 2020 · 7 comments
Closed

wrong self import in skew polynomials #29603

fchapoton opened this issue Apr 27, 2020 · 7 comments
Labels
c: algebra p: minor / 4 t: enhancement
Milestone
sage-9.1

Comments

@fchapoton
Copy link
Contributor

and also clean the pep8 details in the same file

CC: @xcaruso

Component: algebra

Author: Frédéric Chapoton

Branch/Commit: 53d568c

Reviewer: Xavier Caruso

Issue created by migration from https://trac.sagemath.org/ticket/29603
@fchapoton fchapoton added this to the sage-9.2 milestone Apr 27, 2020
@fchapoton
Copy link
Contributor Author

New commits:

53d568cfix wrong self-import in skew_polynomial_ring, plus all pep details

@fchapoton
Copy link
Contributor Author

Commit: 53d568c

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/29603

@fchapoton fchapoton changed the title wrong import in skew polynomials wrong self import in skew polynomials Apr 27, 2020
@xcaruso
Copy link
Contributor

xcaruso commented Apr 27, 2020

comment:2

LGTM.

@mkoeppe
Copy link
Member

mkoeppe commented Apr 27, 2020

comment:3

reviewer name

@xcaruso
Copy link
Contributor

xcaruso commented Apr 27, 2020

Reviewer: Xavier Caruso

@vbraun
Copy link
Member

vbraun commented May 2, 2020

Changed branch from u/chapoton/29603 to 53d568c

@vbraun vbraun closed this as completed in 31666f8 May 2, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.1 May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
4 participants
@vbraun @fchapoton @xcaruso @mkoeppe