Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sage -python", "sage -pip", etc.: Do not fall back to system Python #29627

Closed
mkoeppe opened this issue May 1, 2020 · 10 comments
Closed

"sage -python", "sage -pip", etc.: Do not fall back to system Python #29627

mkoeppe opened this issue May 1, 2020 · 10 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 1, 2020

(from #29626)

With a fresh tarball, sage --pip install PKG doesn't do what I want: since I'm using the system Python, it installs the package in the system location, not in SAGE_ROOT/local/..

(It gives an error for a bootstrapped, unconfigured tree, but calls system python in a configured tree.)

In this ticket, we change all of sage -pip, sage -python, sage -python3 etc. to give an error if Sage's Python has not been built yet (or the venv over the system python3 set up).

CC: @jhpalmieri @dimpase @vbraun

Component: build

Author: Matthias Koeppe

Branch/Commit: 248c13b

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29627

@mkoeppe mkoeppe added this to the sage-9.1 milestone May 1, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented May 1, 2020

comment:1

sage -pip just calls sage-python -m pip.

In fact, sage -python should probably exit with an error if the venv (or Sage's python) has not been created yet.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 1, 2020

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title "sage -pip" should never install into the system Python's site-packages "sage -python", "sage -pip", etc.: Do not fall back to system Python May 1, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented May 1, 2020

@dimpase
Copy link
Member

dimpase commented May 1, 2020

Commit: 248c13b

@dimpase
Copy link
Member

dimpase commented May 1, 2020

comment:5

ok, this makes sense.


New commits:

248c13b"sage -python", "sage -pip", etc.: Do not fall back to system Python

@dimpase
Copy link
Member

dimpase commented May 1, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented May 1, 2020

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented May 4, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants