Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of 28757 #29679

Closed
kliem opened this issue May 12, 2020 · 7 comments
Closed

Cleanup of 28757 #29679

kliem opened this issue May 12, 2020 · 7 comments
Labels
c: geometry p: minor / 4 t: enhancement
Milestone
sage-9.2

Comments

@kliem
Copy link
Contributor

kliem commented May 12, 2020

This is a cleanup of #28757.

I forgot to remove the redundant file src/sage/geometry/polyhedron/combinatorial_polyhedron/bit_vector_operations.pxd.

There is also the wrong description for intersection in polyhedron_face_lattice.pyx.

CC: @jplab

Component: geometry

Keywords: combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: 6c9e848

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29679
@kliem kliem added this to the sage-9.2 milestone May 12, 2020
@kliem
Copy link
Contributor Author

kliem commented May 12, 2020

Branch: public/29679

@kliem
Copy link
Contributor Author

kliem commented May 12, 2020

New commits:

6c9e848cleanup of 28757

@kliem
Copy link
Contributor Author

kliem commented May 12, 2020

Commit: 6c9e848

@tscrim
Copy link
Collaborator

tscrim commented May 13, 2020

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 13, 2020

Reviewer: Travis Scrimshaw

@kliem
Copy link
Contributor Author

kliem commented May 13, 2020

comment:3

Thank you.

@vbraun
Copy link
Member

vbraun commented May 31, 2020

Changed branch from public/29679 to 6c9e848

@vbraun vbraun closed this as completed in d5381d1 May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @kliem