Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksums: print both package name and tarball name #29680

Closed
jhpalmieri opened this issue May 13, 2020 · 10 comments
Closed

Fix checksums: print both package name and tarball name #29680

jhpalmieri opened this issue May 13, 2020 · 10 comments

Comments

@jhpalmieri
Copy link
Member

Currently:

% ./sage --package fix-checksum sage_brial
Checksum of brial-1.2.5.tar.bz2 unchanged

or

% ./sage --package fix-checksum sage_brial
Updating checksum of brial-1.2.8.tar.bz2

This ticket proposes changing the message to

Checksum of sage_brial (tarball brial-1.2.5.tar.bz2) unchanged

or

Updating checksum of sage_brial (tarball brial-1.2.8.tar.bz2)

Component: build

Author: John Palmieri

Branch/Commit: 8dd8523

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/29680

@jhpalmieri jhpalmieri added this to the sage-9.2 milestone May 13, 2020
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/checksum-msg

@jhpalmieri
Copy link
Member Author

New commits:

7551232trac 29680: change message printed by "sage --package fix-checksum"

@jhpalmieri
Copy link
Member Author

Commit: 7551232

@fchapoton
Copy link
Contributor

comment:3

The string "Updating checksum" also appears in build/sage_bootstrap/cmdline.py

And "Checksum of .* unchanged" also in build/test/test_package_cmdline.py

found using git grep

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 14, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

273b816trac 29680: change message printed by "sage --package fix-checksum"
8dd8523trac 29680: documentation and testing fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 14, 2020

Changed commit from 7551232 to 8dd8523

@jhpalmieri
Copy link
Member Author

comment:5

Thanks for the pointer, I've now changed those, too.

@fchapoton
Copy link
Contributor

comment:6

ok, looks good enough

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Jun 3, 2020

Changed branch from u/jhpalmieri/checksum-msg to 8dd8523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants