Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switching between --with-system-python3 and --without-system-python3 #29708

Open
mkoeppe opened this issue May 18, 2020 · 6 comments
Open

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 18, 2020

As noted in build/make/deps (and reported in #27824):

# TODO: If we reconfigure to build our own Python after having used the system
# Python, files installed to create the virtualenv should be *removed*.  That
# could either be done here by the makefile, or in an spkg-preinst for python3

In particular, the symlinks installed by venv together with the flawed copying from DESTDIR (see #29585) can cause the system python to be overwritten (observed on macOS).

#30687 solves this problem using an spkg-legacy-uninstall script.

In this ticket, we develop a cleaner solution by setting up the venv into a script package _venv. Together with #29386 (Install script packages via sage-spkg), this will take care of uninstalling the symlinks before writing the python3 installation to SAGE_LOCAL.

Depends on #29386
Depends on #30687

CC: @mezzarobba @dimpase

Component: packages: standard

Issue created by migration from https://trac.sagemath.org/ticket/29708

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 18, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 10, 2020

Dependencies: #29386

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 10, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 2, 2020

Changed dependencies from #29386 to #29386, #30687

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 13, 2021

comment:5

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant