Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document integer overflow bug in vector_space_dimension() #29746

Closed
kliem opened this issue May 27, 2020 · 10 comments
Closed

Document integer overflow bug in vector_space_dimension() #29746

kliem opened this issue May 27, 2020 · 10 comments

Comments

@kliem
Copy link
Contributor

kliem commented May 27, 2020

We document the following bug reported in #8586

sage: P.<x,y,z> = PolynomialRing(GF(32003),3)
sage: sage.rings.ideal.FieldIdeal(P).vector_space_dimension()
-1973539045 # 2^32 - (32003^3) % 2^32 == 1973539045

Component: commutative algebra

Keywords: sd109

Author: Jonathan Kliem

Branch/Commit: 76d3388

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29746

@kliem kliem added this to the sage-9.2 milestone May 27, 2020
@kliem
Copy link
Contributor Author

kliem commented May 27, 2020

New commits:

a7e3ac5document integer overflow bug

@kliem
Copy link
Contributor Author

kliem commented May 27, 2020

Branch: public/29746

@kliem
Copy link
Contributor Author

kliem commented May 27, 2020

Commit: a7e3ac5

@mkoeppe
Copy link
Member

mkoeppe commented Jun 14, 2020

comment:2

Shouldn't there rather be a test for the correct result, marked # not tested - known bug

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

76d3388show the correct result for the known bug

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2020

Changed commit from a7e3ac5 to 76d3388

@kliem
Copy link
Contributor Author

kliem commented Jun 15, 2020

comment:4

Replying to @mkoeppe:

Shouldn't there rather be a test for the correct result, marked # not tested - known bug

Ok.

Just # known bug works for me and this appears to be the common approach.

@mkoeppe
Copy link
Member

mkoeppe commented Jun 15, 2020

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor Author

kliem commented Jun 15, 2020

comment:6

Thank you.

@vbraun
Copy link
Member

vbraun commented Jul 8, 2020

Changed branch from public/29746 to 76d3388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants