Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect package name for python37-urllib3 on Cygwin in installation guide #29749

Closed
embray opened this issue May 28, 2020 · 8 comments
Closed

incorrect package name for python37-urllib3 on Cygwin in installation guide #29749

embray opened this issue May 28, 2020 · 8 comments
Labels
c: documentation p: minor / 4 t: bug
Milestone
sage-9.2

Comments

@embray
Copy link
Contributor

embray commented May 28, 2020

./build/pkgs/cygwin.txt lists the package name python37-urllib but the correct name of the package is python37-urllib3:

https://cygwin.com/cgi-bin2/package-cat.cgi?file=x86_64%2Fpython37-urllib3%2Fpython37-urllib3-1.24.1-1&grep=urllib

Component: documentation

Keywords: sd109

Author: Erik Bray

Branch/Commit: cd4c063

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/29749
@embray embray added this to the sage-9.2 milestone May 28, 2020
@embray
Copy link
Contributor Author

embray commented May 28, 2020

Branch: u/embray/issue-29749

@embray
Copy link
Contributor Author

embray commented May 28, 2020

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented May 28, 2020

Commit: cd4c063

@embray
Copy link
Contributor Author

embray commented May 28, 2020

New commits:

cd4c063Trac #29749: correct package name for python37-urllib3 on Cygwin

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@mkoeppe
Copy link
Member

mkoeppe commented May 28, 2020

comment:3

Thanks for catching this. Just a quick note -- it's not just "documentation", also the new GitHub CI workflow uses these package lists, see https://github.com/sagemath/sage/actions?query=workflow%3A%22CI+cygwin-standard%22

@mkoeppe
Copy link
Member

mkoeppe commented May 28, 2020

Changed keywords from none to sd109

@vbraun
Copy link
Member

vbraun commented Jun 3, 2020

Changed branch from u/embray/issue-29749 to cd4c063

@vbraun vbraun closed this as completed in 6932618 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
4 participants
@saraedum @embray @vbraun @mkoeppe