Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

werkzeug should be made optional #29752

Closed
jhpalmieri opened this issue May 28, 2020 · 23 comments
Closed

werkzeug should be made optional #29752

jhpalmieri opened this issue May 28, 2020 · 23 comments

Comments

@jhpalmieri
Copy link
Member

The werkzeug package is only used in flask, which was made optional in #29320. So werkzeug should be optional, too.

Component: packages: standard

Keywords: sd109

Author: John Palmieri

Reviewer: Matthias Koeppe, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29752

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/werkzeug-optional

@jhpalmieri
Copy link
Member Author

Changed branch from u/jhpalmieri/werkzeug-optional to none

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/werkzeug-optional

@jhpalmieri
Copy link
Member Author

Commit: 56444d6

@jhpalmieri
Copy link
Member Author

New commits:

56444d6trac 29752: convert werkzeug from standard to optional

@mkoeppe
Copy link
Member

mkoeppe commented May 28, 2020

Reviewer: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from 56444d6 to 27b3d91

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

27b3d91trac 29754: remove packages backported Python 3 components to Python 2.

@jhpalmieri
Copy link
Member Author

comment:6

Sorry, I'll fix that.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from 27b3d91 to ddca85a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ddca85atrac 29752: convert werkzeug from standard to optional

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from ddca85a to 27b3d91

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

56444d6trac 29752: convert werkzeug from standard to optional
27b3d91trac 29754: remove packages backported Python 3 components to Python 2.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ddca85atrac 29752: convert werkzeug from standard to optional
9385b73trac 29754: remove packages backported Python 3 components to Python

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from 27b3d91 to 9385b73

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from 9385b73 to ddca85a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e1a0c8ctrac 29752: convert werkzeug from standard to optional
406a030trac 29754: remove packages backported Python 3 components to Python

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2020

Changed commit from ddca85a to 406a030

@jhpalmieri
Copy link
Member Author

comment:13

(a) I'm having all sorts of problems with my git branches, obviously.

(b) This is made obsolete by #29754. So let's close this one and just use that one.

@jhpalmieri
Copy link
Member Author

Changed branch from u/jhpalmieri/werkzeug-optional to none

@jhpalmieri
Copy link
Member Author

Changed commit from 406a030 to none

@jhpalmieri jhpalmieri removed this from the sage-9.2 milestone May 28, 2020
@dimpase
Copy link
Member

dimpase commented May 28, 2020

Changed reviewer from Matthias Koeppe to Matthias Koeppe, Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants