Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/tox-gcc_spkg.yml: Remove python2 #29757

Closed
mkoeppe opened this issue May 29, 2020 · 19 comments
Closed

.github/workflows/tox-gcc_spkg.yml: Remove python2 #29757

mkoeppe opened this issue May 29, 2020 · 19 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 29, 2020

Follow-up from #29669

Depends on #29669

CC: @dimpase @jhpalmieri @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: eac7eca

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29757

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 29, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented May 29, 2020

Dependencies: #29669

@mkoeppe
Copy link
Member Author

mkoeppe commented May 29, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented May 29, 2020

Last 10 new commits:

6257875Generate External Packages chapter for the reference manual
32bb2feMerge tag '9.1.rc3' into t/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs
7555ba6Merge branch 't/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs' into t/29669/for_sage_9_2__remove_python_2_support_from_the_build_system
520078abuild/pkgs/python2: Remove
f712bb5configure.ac: Remove option --with-python=2
96a5e76Remove python2 from tox and [GitHub](../wiki/GitHub) CI scripts
ea7df3econfigure.ac: Remove message 'Checking for Python version to install...'
ff41817configure.ac: Warn on 'configure --with-python=3.x'
378bf54Merge branch 't/29669/for_sage_9_2__remove_python_2_support_from_the_build_system' into t/29757/_github_workflows_tox_gcc_spkg_yml__remove_python2
225f730.github/workflows/tox-gcc_spkg.yml: Remove python2

@mkoeppe
Copy link
Member Author

mkoeppe commented May 29, 2020

Commit: 225f730

@mkoeppe
Copy link
Member Author

mkoeppe commented May 29, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented May 29, 2020

comment:5

Could you rebase this on #29754 - which removes several Py2 packages this ticket touches.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 29, 2020

comment:6

Actually #29669 did and is already on Volker's branch.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 29, 2020

comment:7

This ticket here really only has 1 commit

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 1, 2020

comment:8

Needs review

@kliem
Copy link
Contributor

kliem commented Jun 1, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jun 1, 2020

comment:9

LGTM.

@kliem
Copy link
Contributor

kliem commented Jun 1, 2020

comment:10

Sorry,

there is a mistake I believe.

-        tox_packages_factor: [minimal-gcc_spkg, standard-gcc_spkg, standard-python2-gcc_spkg]
+        tox_packages_factor: [minimal-gcc_spkg, standard-gcc_spkg, standard]

This third option should probably go completely.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 1, 2020

Changed commit from 225f730 to eac7eca

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 1, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

eac7ecaFixup

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 1, 2020

comment:12

Indeed, thanks for catching this.

@kliem
Copy link
Contributor

kliem commented Jun 1, 2020

comment:14

Now it should be good to go.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 1, 2020

comment:15

Thanks!

@vbraun
Copy link
Member

vbraun commented Jun 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants