Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 6: last) #29791

Closed
mkoeppe opened this issue Jun 3, 2020 · 18 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 3, 2020

Follow-up from #29706.

It takes care of all remaining extensions.

Depends on #29706

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch: 802356a

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29791

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 3, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 3, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 3, 2020

Last 10 new commits:

70901easrc/sage/env.py (cython_aliases): Update doctest
eed920esrc/sage/tests: Move Extension options from src/module_list.py to distutils directives
0d25d1dsrc/sage/structure: Move Extension options from src/module_list.py to distutils directives
808f46asrc/sage/stats: Move Extension options from src/module_list.py to distutils directives
10f7542src/sage/schemes: Move Extension options from src/module_list.py to distutils directives
5867c05src/sage/modular/pollack_stevens/dist.pyx: Add missing distutils directives
c536daaRemove self-listing in distutils sources directive
9dc7022Merge branch 't/29706/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files' into t/29791/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_6__last_
96b99c8src/module_list.py: Move options for Extensions in sage.matrix to distutils directives
2355836src/module_list.py: Move remaining options for Extensions in sage.libs, sage.rings to distutils directives

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 3, 2020

Commit: 2355836

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 3, 2020

Dependencies: #29706

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Changed commit from 2355836 to 6421e2c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 3, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f78b06dsrc/module_list.py: Move options for Extensions in sage.libs to distutils directives
1b0e29dsrc/module_list.py: Move options for Extensions in sage.matrix to distutils directives
6421e2csrc/module_list.py: Move remaining options for Extensions in sage.libs, sage.rings to distutils directives

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2020

Changed commit from 6421e2c to 802356a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

b1b3787sage.env.cython_aliases: Fix for systems without zlib pc
802356aMerge branch 't/29706/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files' into t/29791/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_6__last_

@kliem
Copy link
Contributor

kliem commented Jun 15, 2020

comment:6

What about

+              depends = [SAGE_INC + "/polybori/" + hd + ".h" for hd in ["polybori", "config"]]),

Is that going to stay there? Is this being removed in a different ticket?

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 15, 2020

comment:7

Ah right, that's a loose end...

@kliem
Copy link
Contributor

kliem commented Jun 16, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jun 16, 2020

comment:8

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 16, 2020

comment:9

Thanks!

@vbraun
Copy link
Member

vbraun commented Jun 27, 2020

@dimpase
Copy link
Member

dimpase commented Aug 1, 2020

Changed commit from 802356a to none

@dimpase
Copy link
Member

dimpase commented Aug 1, 2020

comment:11

Is there a follow-up ticket? E.g. the polybori thing in comment:6 is still not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants