Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to generate bigger hypergraphs with nauty using genbgL #29821

Closed
dimpase opened this issue Jun 7, 2020 · 22 comments
Closed

allow to generate bigger hypergraphs with nauty using genbgL #29821

dimpase opened this issue Jun 7, 2020 · 22 comments

Comments

@dimpase
Copy link
Member

dimpase commented Jun 7, 2020

As reported
on sage-support,
bigger hypergraphs are easy to generate if a different nauty routine is used.

Here we implement this.

CC: @slel @dcoudert

Component: graph theory

Keywords: nauty

Author: Dima Pasechnik

Branch/Commit: 03bd63f

Reviewer: David Coudert, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/29821

@dimpase dimpase added this to the sage-9.2 milestone Jun 7, 2020
@dimpase
Copy link
Member Author

dimpase commented Jun 7, 2020

comment:1

branch is coming

@dimpase
Copy link
Member Author

dimpase commented Jun 7, 2020

Commit: c907930

@dimpase
Copy link
Member Author

dimpase commented Jun 7, 2020

Branch: u/dimpase/graphs/genbgL

@dimpase
Copy link
Member Author

dimpase commented Jun 7, 2020

New commits:

c907930replace genbg by genbgL, add tests

@slel
Copy link
Member

slel commented Jun 7, 2020

comment:3

Missing closing double-backtick, and maybe spell out "minus":

- at most 64-``number_of_vertices
+ at most 64 minus ``number_of_vertices``

Missing blank line between

    TESTS::

and the test block it introduces.

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Jun 7, 2020

Changed keywords from none to nauty

@slel slel changed the title allow to generate bigger hypergraphs with nauty allow to generate bigger hypergraphs with nauty using genbgL Jun 7, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2020

Changed commit from c907930 to 14d8d51

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

14d8d51typos noted by reviewer

@dimpase
Copy link
Member Author

dimpase commented Jun 7, 2020

comment:5

ok, fixed

@dimpase
Copy link
Member Author

dimpase commented Jun 17, 2020

comment:6

ping?

@dcoudert
Copy link
Contributor

comment:8

may be it's time to update the link to nauty to https://pallini.di.uniroma1.it

also, some pep8 comments

-        if number_of_sets+number_of_vertices > 64:
+        if number_of_sets + number_of_vertices > 64:
-        sp = subprocess.Popen(nautyprefix+"genbgL {0}".format(nauty_input), shell=True,
+        sp = subprocess.Popen(nautyprefix + "genbgL {0}".format(nauty_input), shell=True,

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 18, 2020

Changed commit from 14d8d51 to 03bd63f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 18, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

03bd63fPEP8 fixes

@dimpase
Copy link
Member Author

dimpase commented Jun 18, 2020

comment:10

fixed PEP8 - and will do the URL changes on nauty update ticket.

@dcoudert
Copy link
Contributor

comment:11

LGTM.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dimpase
Copy link
Member Author

dimpase commented Jun 18, 2020

comment:12

I checked that both uniroma and ANU urls are mentioned in SPKG-install.txt
And, by the way, please review the nauty update ticket #26891

@dimpase
Copy link
Member Author

dimpase commented Jun 18, 2020

comment:13

Replying to @dcoudert:

LGTM.

Thanks

@slel
Copy link
Member

slel commented Jun 18, 2020

Changed reviewer from David Coudert to David Coudert, Samuel Lelièvre

@slel
Copy link
Member

slel commented Jun 18, 2020

comment:14

Thanks!

@vbraun
Copy link
Member

vbraun commented Jun 27, 2020

Changed branch from u/dimpase/graphs/genbgL to 03bd63f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants