Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sage -twistd from src/bin/sage #29878

Closed
jhpalmieri opened this issue Jun 16, 2020 · 6 comments
Closed

Remove sage -twistd from src/bin/sage #29878

jhpalmieri opened this issue Jun 16, 2020 · 6 comments

Comments

@jhpalmieri
Copy link
Member

There is no twistd executable anymore, since the twisted package is being removed in #29754. So let's remove the corresponding command-line option to sage.

Component: scripts

Author: John Palmieri

Branch/Commit: b200d70

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29878

@jhpalmieri jhpalmieri added this to the sage-9.2 milestone Jun 16, 2020
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/no-twistd-argument

@jhpalmieri
Copy link
Member Author

New commits:

b200d70trac 29878: remove "sage --twistd" command-line argument

@jhpalmieri
Copy link
Member Author

Commit: b200d70

@jhpalmieri
Copy link
Member Author

comment:3

By the way, for a separate ticket: the OS X app could use some attention. If I run git grep twistd src, I see

src/mac-app/AppController.m:    NSString *pidFile = [@"~/.sage/sage_notebook.sagenb/twistd.pid" stringByStandardizingPath];
src/mac-app/English.lproj/MainMenu.nib/designable.nib:                                        <menuItem title="twistd" id="1456">
src/mac-app/English.lproj/MainMenu.nib/designable.nib:                                        <menuItem title="twistd" id="1603">
Binary file src/mac-app/English.lproj/MainMenu.nib/keyedobjects.nib matches
src/mac-app/sage-is-running-on-port.sh:if [ ! -e "$PID_FILE" ] && [ -e ~/.sage/sage_notebook.sagenb/twistd.pid ]; then
src/mac-app/sage-is-running-on-port.sh:    PID_FILE=${1-~/.sage/sage_notebook.sagenb/twistd.pid}
src/mac-app/sage-is-running-on-port.sh:    if [ ! -e "$PID_FILE" ] && [ -e ~/.sage/sage_notebook.sagenb/twistd.pid ]; then
src/mac-app/sage-is-running-on-port.sh:        PID_FILE=${1-~/.sage/sage_notebook.sagenb/twistd.pid}

I don't know anything about Mac apps, so I don't know if this is anything to be concerned about.

@mkoeppe
Copy link
Member

mkoeppe commented Jun 16, 2020

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Jul 8, 2020

Changed branch from u/jhpalmieri/no-twistd-argument to b200d70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants