Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial-like docstring material on RecursivelyEnumeratedSet #29882

Closed
mkoeppe opened this issue Jun 17, 2020 · 17 comments
Closed

Add tutorial-like docstring material on RecursivelyEnumeratedSet #29882

mkoeppe opened this issue Jun 17, 2020 · 17 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 17, 2020

... from a forgotten branch on #16351 ...

CC: @hivert @tscrim @seblabbe @nthiery @slel

Component: combinatorics

Author: Florent Hivert, Sébastien Labbé

Branch/Commit: 90dc326

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29882

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 17, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 17, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 17, 2020

Commit: 1bf8c97

@seblabbe
Copy link
Contributor

Author: Florent Hivert, Sébastien Labbé

@seblabbe
Copy link
Contributor

Changed commit from 1bf8c97 to 8b9869f

@seblabbe
Copy link
Contributor

comment:3

I just did few modifications to properly include Florent's example into the doc.


New commits:

cb48f33Revert "Removed TODO in doc"
8b9869f29882: including the two examples provided by Florent Hivert into docstring

@seblabbe
Copy link
Contributor

@seblabbe
Copy link
Contributor

comment:4

Note that I rebased old Florent Hivert's commit on top of 9.2.beta1 (new commit hash is cb48f33).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 2, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

46cce8fMerge branch 'public/29882' of git://trac.sagemath.org/sage into public/29882
b44aac2Some reviewer changes.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 2, 2020

Changed commit from 8b9869f to b44aac2

@tscrim
Copy link
Collaborator

tscrim commented Jul 2, 2020

comment:6

I made a few small changes to try and improve the exposition. If my changes are good, then positive review.

@tscrim
Copy link
Collaborator

tscrim commented Jul 2, 2020

Reviewer: Travis Scrimshaw

@mwageringel
Copy link

comment:7

There are a few lines which are syntax errors in Python 3:

    def children((lst, st)):
        post_process = lambda (l, s): tuple(l) if not s else None,

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 13, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

0a8c6d8Merge branch 'public/29882' of trac.sagemath.org:/sage into 29882
90dc32629882: adapted examples to Python3 syntax

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 13, 2020

Changed commit from b44aac2 to 90dc326

@seblabbe
Copy link
Contributor

comment:9

Needs review.

@tscrim
Copy link
Collaborator

tscrim commented Jul 17, 2020

comment:10

LGTM.

@vbraun
Copy link
Member

vbraun commented Jul 25, 2020

Changed branch from public/29882 to 90dc326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants