Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite to check method dilation #29907

Closed
kliem opened this issue Jun 19, 2020 · 18 comments
Closed

Run test suite to check method dilation #29907

kliem opened this issue Jun 19, 2020 · 18 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jun 19, 2020

We add a method to Polyhedron_base that tests the method dilation.

This ticket discovered a bug that is fixed in #29899.

Depends on #29899
Depends on #29903
Depends on #29905

CC: @jplab @LaisRast

Component: geometry

Keywords: polyhedra, test suite

Author: Jonathan Kliem

Branch/Commit: 25152f6

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29907

@kliem kliem added this to the sage-9.2 milestone Jun 19, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 19, 2020

Branch: public/29907

@kliem
Copy link
Contributor Author

kliem commented Jun 19, 2020

Commit: 3cb69aa

@kliem
Copy link
Contributor Author

kliem commented Jun 19, 2020

Last 10 new commits:

5c7e562fix double description of hypercube
206dbb7merged in public/29904
c6ea1ecadded long time flags
5d79b2bsome more testsuites
e41d698fix universe from Hrep for cdd
e055bc7correctly detect the empty polyhedron
7eba64dtrivial inequality
067fb16also fix it for initialization from Hrep and Vrep
3a6559bMerge branch 'public/29899' of git://trac.sagemath.org/sage into public/29907
3cb69aaadd _test_dilation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Changed commit from 3cb69aa to bb6110c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

bb6110cpyflakes

@kliem
Copy link
Contributor Author

kliem commented Jun 22, 2020

Changed dependencies from #29899, #29903 to #29899, #29903, #29905

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

6eaf649test some basic properties
d91c526Merge branch 'public/29905' of git://trac.sagemath.org/sage into public/29907
966210ereally test the correct double description

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Changed commit from bb6110c to 966210e

@kliem
Copy link
Contributor Author

kliem commented Jun 22, 2020

comment:5

It turns out that the equality check doesn't always detect if a polyhedron is set up correctly. It just assumes this. It will discover this in many instances, but there is no guarantee.

On the other hand the method _test_basic_properties was just introduced to do precisely that (and some other basic properties).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Changed commit from 966210e to 75b97b4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

75b97b4typo

@mkoeppe
Copy link
Member

mkoeppe commented Jul 19, 2020

comment:7

Needs rebase

@kliem
Copy link
Contributor Author

kliem commented Jul 19, 2020

Changed commit from 75b97b4 to 25152f6

@kliem
Copy link
Contributor Author

kliem commented Jul 19, 2020

Changed branch from public/29907 to public/29907-reb

@kliem
Copy link
Contributor Author

kliem commented Jul 19, 2020

New commits:

9a57836fixed merge conflict
25152f6small fix

@mkoeppe
Copy link
Member

mkoeppe commented Jul 19, 2020

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor Author

kliem commented Jul 19, 2020

comment:10

Thank you.

@vbraun
Copy link
Member

vbraun commented Jul 28, 2020

Changed branch from public/29907-reb to 25152f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants