Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tox as a type=optional, source=pip package #29909

Closed
mkoeppe opened this issue Jun 20, 2020 · 10 comments
Closed

Add tox as a type=optional, source=pip package #29909

mkoeppe opened this issue Jun 20, 2020 · 10 comments
Labels
c: packages: optional p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 20, 2020

Follow-up to #29813, which did the same for pytest.

Depends on #29813

CC: @dimpase @jhpalmieri @kiwifb

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 1c2415e

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29909
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 20, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 20, 2020

Changed dependencies from #29345 to #29813

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 20, 2020

Branch: u/mkoeppe/add_tox_as_a_type_optional__source_pip_package

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 20, 2020

Commit: 1c2415e

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 20, 2020

New commits:

04b4c67build/pkgs/pytest: New
55babfasrc/bin/sage [-i]: Set SAGE_CHECK here so that Makefile dependencies can depend on it
bedc7aebuild/make/Makefile.in: Allow pip packages as dependencies
1c2415ebuild/pkgs/tox: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 20, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@dimpase
Copy link
Member

dimpase commented Jul 2, 2020

comment:5

lgtm

@dimpase
Copy link
Member

dimpase commented Jul 2, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 2, 2020

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 8, 2020

Changed branch from u/mkoeppe/add_tox_as_a_type_optional__source_pip_package to 1c2415e

@vbraun vbraun closed this as completed in bfacdd6 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe