Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some new functionality and doctests for congruence subgroups #2995

Closed
aghitza opened this issue Apr 22, 2008 · 4 comments
Closed

some new functionality and doctests for congruence subgroups #2995

aghitza opened this issue Apr 22, 2008 · 4 comments

Comments

@aghitza
Copy link

aghitza commented Apr 22, 2008

The attached patch does the following:

  1. allow coercing a 2x2 matrix (or a list of 4 elements) into a congruence subgroup: Gamma0(5)([1,5,1,6]) now works

  2. modified G.generators() so that it actually returns a list of elements of the group G instead of just matrices

  3. added gens()

  4. added a bunch of doctests

Right now, all these changes are for Gamma0 and Gamma1 subgroups; I will do the same with GammaH subgroups as soon as I figure out how these work.

Component: modular forms

Keywords: congruence subgroup

Issue created by migration from https://trac.sagemath.org/ticket/2995

@aghitza
Copy link
Author

aghitza commented Apr 23, 2008

comment:1

Attachment: congroup.patch.gz

I've replaced the previous patch with one that also has the changes listed above for the groups Gamma_H.

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Apr 25, 2008

comment:2

Patch looks good, doctests are good too.

I hate the name acton -- it looks like a typoed action. Could we change that to act_on?

@ncalexan ncalexan mannequin added the s: positive review label Apr 25, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 26, 2008

comment:3

Merged in Sage 3.0.1.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Apr 26, 2008
@aghitza
Copy link
Author

aghitza commented Apr 26, 2008

comment:4

Nick: good point about acton(). I am planning to do some more work on congroup.py and friends, and I'll fix this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants