New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduction from dancing links instance to MILP instance #29955
Comments
Commit: |
Branch: u/slabbe/29955 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Author: Sébastien Labbé |
comment:4
I found two issues with the doctests. I'll post them as two separate comments. First, there is a doctest error (all the variables in the constraints are named
|
comment:5
Second, the answer I get from the following doctest does not agree with the answer specified in the doctest.
The doctest says the above should be:
I'm not sure why this error is not caught by the doctest system. |
comment:6
Replying to @saliola:
I just learned about the
then I see two doctest failures. |
comment:7
I made some changes to address the second doctest problem above and I've updated the branch. Hopefully I didn't mess up.... New commits:
|
Changed branch from u/slabbe/29955 to public/29955 |
comment:8
OK, it seems I was able to correctly create and set a public branch for this ticket. Any ideas on what to do for the doctest for |
comment:9
Yes indeed, I wanted to write
...as you fixed it is okay as well. On another machine running a more recent version of Sage, with the current public branch, I get:
(The licence of my Gurobi licence just expired. I need to renew it.) So the error with the |
comment:10
I was using sage version 9.1rc1 because that is what the branch switched too. I'll update to the develop version and test again. |
comment:11
I figured out what is causing the error with the |
comment:13
Thank you so much for this Sébastien! |
comment:14
Replying to @saliola:
Upstream is https://github.com/mkoeppe/sage-numerical-backends-gurobi |
Reviewer: Franco Saliola |
comment:16
Thank you for your review Franco! |
comment:17
Thank you. I created an issue upstream with an example that does not require this ticket; see sagemath/sage-numerical-backends-gurobi#2 |
Changed reviewer from Franco Saliola to none |
comment:18
Replying to @mkoeppe: I just created |
comment:19
oups, we did the same thing at the same time! |
Reviewer: Franco Saliola |
This comment has been minimized.
This comment has been minimized.
comment:22
A quick comment. I think |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:24
I agree. I just did a commit. Hoping that Volker did not started to merge that ticket while it was on positive review status. Needs review. |
Changed reviewer from Franco Saliola to Franco Saliola, Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Changed branch from public/29955 to |
Following #29338, the proposed branch adds 2 new methods which allows what follows:
This is based on the new method:
Depends on #29338
CC: @slel
Component: combinatorics
Author: Sébastien Labbé
Branch/Commit:
da23ad1
Reviewer: Franco Saliola, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/29955
The text was updated successfully, but these errors were encountered: