Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make algebras doctests ready for random seeds #29968

Closed
kliem opened this issue Jun 24, 2020 · 16 comments
Closed

Make algebras doctests ready for random seeds #29968

kliem opened this issue Jun 24, 2020 · 16 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/sage/algebras/

pass for different values n than just 0.

Depends on #29962

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: 46c0147

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/29968

@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Changed dependencies from #29662 to #29962

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Branch: public/29968

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Commit: 72d4116

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
72d4116make algebras fuzz ready

@kliem
Copy link
Contributor Author

kliem commented Jul 11, 2020

comment:3

Currently this QuaternionAlgebra(-11,-1).maximal_order().random_element() gives and element of QuaternionAlgebra(-11,-1). This seems somewhat strange to me.


New commits:

95a2fefMerge branch 'public/29968' of git://trac.sagemath.org/sage into public/29968-reb
445beefbetter doctests

@kliem
Copy link
Contributor Author

kliem commented Jul 11, 2020

Changed branch from public/29968 to public/29968-reb

@kliem
Copy link
Contributor Author

kliem commented Jul 11, 2020

Changed commit from 72d4116 to 445beef

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2020

Changed commit from 445beef to 8038412

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

8038412fix doctest

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

New commits:

b31e2d5Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962-reb
2f30dd9small fixes
b62f781doctests do not start from a random seed by default yet
1d99129fix merge conflict
46c0147Merge branch 'public/29968-reb' of git://trac.sagemath.org/sage into public/29968-reb2

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

Changed branch from public/29968-reb to public/29968-reb2

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

Changed commit from 8038412 to 46c0147

@mwageringel
Copy link

comment:6

Ok.

@mwageringel
Copy link

Reviewer: Markus Wageringel

@kliem
Copy link
Contributor Author

kliem commented Aug 14, 2020

comment:7

Thank you.

@vbraun
Copy link
Member

vbraun commented Aug 16, 2020

Changed branch from public/29968-reb2 to 46c0147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants