Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of _cmp_ for list_clone #30077

Closed
fchapoton opened this issue Jul 6, 2020 · 7 comments
Closed

get rid of _cmp_ for list_clone #30077

fchapoton opened this issue Jul 6, 2020 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.2

Comments

@fchapoton
Copy link
Contributor

as another step towards removal of _cmp_

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: abee232

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30077
@fchapoton fchapoton added this to the sage-9.2 milestone Jul 6, 2020
@fchapoton
Copy link
Contributor Author

Commit: abee232

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30077

@fchapoton
Copy link
Contributor Author

New commits:

abee232get rid of `_cmp_` in list_clone.pyx

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review.

Travis, are things all right in Queensland ?

@tscrim
Copy link
Collaborator

tscrim commented Jul 6, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 6, 2020

comment:3

Replying to @fchapoton:

green bot, please review.

LGTM.

Travis, are things all right in Queensland ?

Things are going fairly well. In the middle of finals still, but that is almost over. The state's borders reopened ahead of schedule this past weekend (however Melbourne is not doing so well right now). I am now ready for my poster at FPSAC. Although the big thing I am (still) waiting for is the international border to reopen.

How are things for you?

@vbraun
Copy link
Member

vbraun commented Jul 12, 2020

Changed branch from u/chapoton/30077 to abee232

@vbraun vbraun closed this as completed in feb50df Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton