sage.libs.ecl: Make it possible to convert Python strings to Lisp strings

[mkoeppe]

sage.libs.ecl exposes no Python function that converts a Python string to a Lisp string as an EclObject.

(python_to_ecl, which is used by EclObject.__init__, handles strings by READing from them, so EclObject("abc") returns an interned symbol, not a string.)

We add an argument to python_to_ecl and EclObject.__init__ that controls how strings are handled.

Depends on #30106

CC: @nbruin @dimpase @spaghettisalat @mwageringel

Component: interfaces

Author: Matthias Koeppe

Branch/Commit: b6cea1a

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30105

[mkoeppe]

comment:2

In fact, perhaps it would also make sense to add an optional argument to python_to_ecl and EclObject.__init__ that controls whether Python strings (which may also be nested in lists etc.) are merely converted (using the new function) or READ from.

[dimpase]

comment:4

how about making use of things like ecl_to_double() to send data between Python and Maxima?

[mkoeppe]

comment:5

Replying to @dimpase:

how about making use of things like ecl_to_double() to send data between Python and Maxima?

This is the opposite direction of conversion, and these functions are already used in ecl_to_python.

[mkoeppe]

comment:6

Replying to @mkoeppe:

In fact, perhaps it would also make sense to add an optional argument to python_to_ecl and EclObject.__init__ that controls whether Python strings (which may also be nested in lists etc.) are merely converted (using the new function) or READ from.

I have revised the ticket description accordingly.

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Branch: u/mkoeppe/sage_libs_ecl__add_python_function_ecl_make_string

[mkoeppe]

Commit: 70a6351

[mkoeppe]

New commits:

70a6351

sage.libs.ecl.EclObject.__init__: Add optional argument read_strings

[mkoeppe]

comment:10

This works but the unicode handling needs to be improved.

sage: from sage.libs.ecl import *
sage: fire = EclObject('🔥', False)
sage: fire
<ECL: "🔥">
sage: _length = ecl_eval('''#'length''')
sage: _length(fire)
<ECL: 4>
sage: _type_of = ecl_eval('''#'type-of''')
sage: _type_of(fire)
<ECL: (SIMPLE-ARRAY BASE-CHAR (4))>

[mkoeppe]

comment:11

For unicode issues, see #30106.

Let's ignore them here to keep the ticket limited in scope.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

12447bc	reject old makeinfo
a3e0eca	add upstream fix from MR 215
89b006b	add the patch from upstream MR 214
0b77737	add upstream MR 216 (to fix cygwin fork)
8ca1c0e	Merge tag '9.2.beta2' into t/22191/public/packages/ecl20
f82c716	Commit 75877dd8 from upstream
2d87ee3	Merge commit 'f82c716fdf9c6e91a07166d36b6329a15ecfb41d' of git://trac.sagemath.org/sage into t/30106/sage_libs_ecl__fix_unicode_handling
828a727	Add doctests
0bfaccf	Merge branch 't/30106/sage_libs_ecl__fix_unicode_handling' into t/30105/sage_libs_ecl__add_python_function_ecl_make_string
dd27b33	sage.libs.ecl: Update uses of python_to_ecl

[sagetrac-git]

Changed commit from 70a6351 to dd27b33

[mkoeppe]

Dependencies: #30106

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

99b894a	print_objects: Handle unicode
59dd62b	ecl_eval: Make docstring raw
b6cea1a	Merge branch 't/30106/sage_libs_ecl__fix_unicode_handling' into t/30105/sage_libs_ecl__add_python_function_ecl_make_string

[sagetrac-git]

Changed commit from dd27b33 to b6cea1a

[mkoeppe]

comment:15

Merged latest version of #30106. Needs review

[dimpase]

Reviewer: Dima Pasechnik

[dimpase]

comment:16

lgtm

[mkoeppe]

comment:17

Thanks!

[vbraun]

Changed branch from u/mkoeppe/sage_libs_ecl__add_python_function_ecl_make_string to b6cea1a