Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in sagelib setup.py #30113

Closed
mkoeppe opened this issue Jul 11, 2020 · 8 comments
Closed

Fix error handling in sagelib setup.py #30113

mkoeppe opened this issue Jul 11, 2020 · 8 comments
Labels
c: build p: critical / 2 t: bug
Milestone
sage-9.2

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jul 11, 2020

This was broken in #29702 (Move all code from src/setup.py, src/fpickle_setup.py to sage_setup). On compilation errors, we see:

Error in sys.excepthook:
TypeError: 'module' object is not callable

This ticket fixes it.

CC: @vbraun @jhpalmieri @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 47dcbbe

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30113
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 11, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 11, 2020

Branch: u/mkoeppe/fix_error_handling_in_sagelib_setup_py

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 11, 2020

New commits:

47dcbbesrc/setup.py: Fix error handling

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 11, 2020

Commit: 47dcbbe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 11, 2020

Author: Matthias Koeppe

@jhpalmieri
Copy link
Member

comment:3

LGTM.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 12, 2020

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 12, 2020

Changed branch from u/mkoeppe/fix_error_handling_in_sagelib_setup_py to 47dcbbe

@vbraun vbraun closed this as completed in cd041d1 Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe