Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken experimental package scons #30155

Closed
mkoeppe opened this issue Jul 16, 2020 · 17 comments
Closed

Remove broken experimental package scons #30155

mkoeppe opened this issue Jul 16, 2020 · 17 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jul 16, 2020

It is unused and not compatible with python3. It was made experimental in #28687.

https://github.com/mkoeppe/sage/runs/876312062

  [scons-1.2.0]   ****************************************************
  [scons-1.2.0]   Package 'scons' is currently not installed
  [scons-1.2.0]   No legacy uninstaller found for 'scons'; nothing to do
  [scons-1.2.0]     File "setup.py", line 336
  [scons-1.2.0]       mode = ((os.stat(file)[stat.ST_MODE]) | 0555) & 07777
  [scons-1.2.0]                                                  ^
  [scons-1.2.0]   SyntaxError: invalid token
  [scons-1.2.0]   Error installing scons

CC: @jhpalmieri @dimpase @fchapoton

Component: packages: experimental

Author: Matthias Koeppe, John Palmieri

Branch/Commit: 41a3e66

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30155

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 16, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 16, 2020

Changed branch from u/mkoeppe/remove_broken_experimental_package_scons to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 16, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 16, 2020

@dimpase
Copy link
Member

dimpase commented Jul 16, 2020

Commit: 68bfa4b

@dimpase
Copy link
Member

dimpase commented Jul 16, 2020

comment:4

also

$ grep -R scons src/doc/ 
src/doc/en/reference/repl/options.txt:  --scons [...]       -- run Sage's scons
src/doc/en/reference/spkg/index.rst:   scons
src/doc/en/reference/spkg/scons.rst:Website: http://www.scons.org/
src/doc/en/reference/spkg/scons.rst:-  SCons mailing lists - see http://www.scons.org/lists.php

got to go.


New commits:

68bfa4bbuild/pkgs/scons: Remove

@dimpase
Copy link
Member

dimpase commented Jul 16, 2020

comment:5

there is also stuff in COPYING.txt

COPYING.txt:scons                       MIT License

@jhpalmieri
Copy link
Member

@jhpalmieri
Copy link
Member

comment:7

The other option is to upgrade it, but I don't see much motivation to do that.


New commits:

41a3e66trac 30155: remove "sage --scons", remove scons info from COPYING.txt

@jhpalmieri
Copy link
Member

Changed commit from 68bfa4b to 41a3e66

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 16, 2020

Changed author from Matthias Koeppe to Matthias Koeppe, John Palmieri

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 16, 2020

comment:9

Replying to @dimpase:

also

$ grep -R scons src/doc/ 
src/doc/en/reference/repl/options.txt:  --scons [...]       -- run Sage's scons
src/doc/en/reference/spkg/index.rst:   scons
src/doc/en/reference/spkg/scons.rst:Website: http://www.scons.org/
src/doc/en/reference/spkg/scons.rst:-  SCons mailing lists - see http://www.scons.org/lists.php

These are all autogenerated. Ready for review

@jhpalmieri
Copy link
Member

comment:10

Replying to @mkoeppe:

Replying to @dimpase:

also

$ grep -R scons src/doc/ 
src/doc/en/reference/repl/options.txt:  --scons [...]       -- run Sage's scons
src/doc/en/reference/spkg/index.rst:   scons
src/doc/en/reference/spkg/scons.rst:Website: http://www.scons.org/
src/doc/en/reference/spkg/scons.rst:-  SCons mailing lists - see http://www.scons.org/lists.php

These are all autogenerated. Ready for review

Right; git grep scons doesn't show them. I do see

src/mac-app/English.lproj/MainMenu.nib/designable.nib:
   <menuItem title="scons" id="1386">
src/mac-app/English.lproj/MainMenu.nib/designable.nib:
   <menuItem title="scons" id="1604">

but I'm not worrying about those.

@dimpase
Copy link
Member

dimpase commented Jul 16, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jul 16, 2020

comment:11

these things in mac-app can be cleaned up on the ticket for cleaning up sws files from there.

(Is mac-app actually alive?
I can play around with Xcode to try to update it, we just got a newish MacPB from the office with macOS 10.15 - but I can't promise any timeline on this)

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 16, 2020

comment:12

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 28, 2020

Changed branch from u/jhpalmieri/remove_broken_experimental_package_scons to 41a3e66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants