Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Examples to Manifolds Catalog #30189

Open
mjungmath opened this issue Jul 21, 2020 · 22 comments
Open

Add Examples to Manifolds Catalog #30189

mjungmath opened this issue Jul 21, 2020 · 22 comments

Comments

@mjungmath
Copy link

The current catalog is nice to have but still very limited or incomplete. Constructing some examples in the current catalog also takes a lot of time.

While improving and extend this, it is also a good opportunity to expand the tutorials a little bit. Furthermore, most of our docstring examples are based on the 2-sphere. Hence we can perhaps shorten or simplify some parts of the documentation.

Step 1: rearrange folder structure (#30799)

Step 2: unification/improvement/extension of preexisting models

Step 3: add new examples

Step 4: improve the tutorial/doctests

  • simplify preexisting 2-sphere examples
  • add thorough tutorial with old/new models

CC: @egourgoulhon @tscrim @tobiasdiez

Component: manifolds

Issue created by migration from https://trac.sagemath.org/ticket/30189

@mjungmath mjungmath added this to the sage-9.2 milestone Jul 21, 2020
@egourgoulhon
Copy link
Member

comment:1

This sounds like a very good idea!

Note that in order not to clutter the global namespace, one can let access to the sphere and the hyperbolic space via the manifold catalog. The current version of the catalog is very primitive and the function Sphere() in it should call the constructor the sphere class, as soon as the latter is ready.

@mjungmath
Copy link
Author

comment:2

Replying to @egourgoulhon:

This sounds like a very good idea!

Note that in order not to clutter the global namespace, one can let access to the sphere and the hyperbolic space via the manifold catalog. The current version of the catalog is very primitive and the function Sphere() in it should call the constructor the sphere class, as soon as the latter is ready.

Ah, that is very nice. Actually, I was not aware that something like that exists. This should be populated somewhere more obvious. Probably in a tutorial?

So, the only thing that should be added now is the hyperbolic space, right?

@mjungmath
Copy link
Author

comment:3

By the way, I noticed that the result coming from sage.manifolds.catalog.Sphere is not even correct:

sage: S.<th, ph> = manifolds.Sphere()
sage: S
2-dimensional Riemannian submanifold S embedded in the Euclidean
 space E^3
sage: S.atlas()
[Chart (S, (th, ph))]

This is not a correct atlas.

@egourgoulhon
Copy link
Member

comment:4

Replying to @mjungmath:

Ah, that is very nice. Actually, I was not aware that something like that exists. This should be populated somewhere more obvious. Probably in a tutorial?

Indeed, when it is more developed.

So, the only thing that should be added now is the hyperbolic space, right?

No, there remains to introduce a proper sphere class, on the model of EuclideanSpace, with methods like stereographic_coordinates.

@egourgoulhon
Copy link
Member

comment:5

Replying to @mjungmath:

By the way, I noticed that the result coming from sage.manifolds.catalog.Sphere is not even correct:

sage: S.<th, ph> = manifolds.Sphere()
sage: S
2-dimensional Riemannian submanifold S embedded in the Euclidean
 space E^3
sage: S.atlas()
[Chart (S, (th, ph))]

This is not a correct atlas.

Indeed. As I say in comment:1, the catalog is in a primitive stage.

@mjungmath
Copy link
Author

comment:6

Now I see what you mean. I first thought that "primitive" was just referring to the amount of examples.

That's good: there's still work to do. :)

@mjungmath

This comment has been minimized.

@mjungmath mjungmath changed the title Add Sphere and Hyperbolic Space Permanently Add Models to Manifolds Catalog Oct 20, 2020
@mjungmath

This comment has been minimized.

@mjungmath

This comment has been minimized.

@mjungmath

This comment has been minimized.

@mjungmath mjungmath changed the title Add Models to Manifolds Catalog Add Examples to Manifolds Catalog Oct 21, 2020
@mjungmath

This comment has been minimized.

@mjungmath

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mjungmath

This comment has been minimized.

@mjungmath

This comment has been minimized.

@mjungmath

This comment has been minimized.

@mkoeppe
Copy link
Member

mkoeppe commented Feb 13, 2021

comment:18

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe
Copy link
Member

mkoeppe commented Mar 30, 2021

comment:19

There is also some old code in sage.geometry.riemannian_manifolds that seems to provide some examples

@egourgoulhon
Copy link
Member

comment:20

Replying to @mkoeppe:

There is also some old code in sage.geometry.riemannian_manifolds that seems to provide some examples

Indeed! These examples should be integrated into the catalog and then sage.geometry.riemannian_manifolds should be deprecated, since all the functionalities it contains are available in sage.manifolds.differentiable.pseudo_riemannian_submanifold.

@mkoeppe

This comment has been minimized.

@egourgoulhon

This comment has been minimized.

@egourgoulhon

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@egourgoulhon

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants