Fix gp2c spkg-configure

[mkoeppe]

https://groups.google.com/d/msg/sage-devel/rZpwyAT2EZU/jiNWFinQBgAJ

Broken in b5d16d9 (#29491)

CC: @dimpase @orlitzky @slel

Component: build: configure

Keywords: pari, gp2c, pari.cfg

Author: Michael Orlitzky

Branch/Commit: 252633c

Reviewer: Samuel Lelièvre, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30231

[orlitzky]

Branch: u/mjo/ticket/30231

[orlitzky]

Author: Michael Orlitzky

[orlitzky]

Commit: 8f1b8bd

[orlitzky]

comment:1

I need to think about this a little harder, but this new spkg-configure seems to do the trick. The basic problem is that the check phase itself can be skipped with --with-system-gp2c=no, but the location of pari.cfg is needed regardless. Therefore we can't do any calculation that affects discovery of pari.cfg in the check phase. The new version does it all in pre/post-check instead.

---

New commits:

8f1b8bd

Trac #30231: compute libpari_pari_cfg entirely in pre-post/check.

[sagetrac-git]

Changed commit from 8f1b8bd to 252633c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

252633c

Trac #30231: compute libpari_pari_cfg entirely in pre-post/check.

[dimpase]

comment:3

SAGE_SPKG_DEPCHECK was never meant to be called in pre-post/check (certainly never tested to do this, I think).
Not sure whether this will work, without testing all the corner cases.

[mkoeppe]

comment:4

Please run it on GitHub CI and post the link...

[slel]

comment:5

Lacking m4 skills to do a full review, but this
solves the problem I reported on sage-devel for me.

[mkoeppe]

comment:6

Tests run at https://github.com/mkoeppe/sage/actions/runs/188912339

[mkoeppe]

comment:7

The run hasn't quite completed yet, but it's looking fine (as expected)

[mkoeppe]

Reviewer: Samuel Lelièvre, Matthias Koeppe

[orlitzky]

comment:10

Someday pari should be able to tell us where it put that stupid file, but until then, I can't think of a better way to do it than this.

[slel]

Changed keywords from none to pari, gp2c, pari.cfg

[dimpase]

comment:12

Replying to @orlitzky:

Someday pari should be able to tell us where it put that stupid file, but until then, I can't think of a better way to do it than this.

I discussed this with upstream. The response was that it is left to pari/gp users to place it anywhere they want, full stop.

[vbraun]

Changed branch from u/mjo/ticket/30231 to 252633c